From: Michael M. <gh...@xt...> - 2002-10-15 07:21:08
Attachments:
bad-implements-indent.patch
|
1) The implements value is indented improperly in CVS eg public class Wiggles extends Foo implements Fooable { when it should be public class Wiggles extends Foo implements Fooable { 2) get an index out of bounds when printing an array initialiser like this: (trys to access markers.getLast() when there isnt one ) String[] array = {"asdfasd","asdfasd"} 3) Praise :-D It took me a little while to get my head around the source, but I have to say its all very well done. Good work. Any plans to move to Maven or Krysalis for the building. Although you do have a nice setup already. Michael -- Michael McCallum Software Engineer SnapHire Inc. http://www.SnapHire.com/ |
From: Michael M. <gh...@xt...> - 2002-10-15 07:45:36
Attachments:
bad-implements-indent.patch
|
forgot to unindent :-$ -- Michael McCallum Software Engineer SnapHire Inc. http://www.SnapHire.com/ |
From: Marco H. <dev...@hu...> - 2002-10-15 21:20:08
|
Hello Michael, Michael> 1) The implements value is indented improperly in CVS Michael> eg Michael> public class Wiggles Michael> extends Foo Michael> implements Fooable { Michael> when it should be Michael> public class Wiggles Michael> extends Foo Michael> implements Fooable { I'll look at it, but I think my dev-version does it right (I will commit changes soon) Michael> 2) get an index out of bounds when printing an array Michael> initialiser like this: (trys to access markers.getLast() Michael> when there isnt one) Yep, showed up during my testing a few weeks ago. Already fixed on my drive. But I'll look at your patch anyway. Maybe it is better. Michael> 3) Praise :-D Michael> It took me a little while to get my head around the source, Michael> but I have to say its all very well done. Michael> Good work. We're making our way to a first stable version. 1.0b9 will be a *big* improvement as a german insurance company was willing to do *much* field testing. Michael> Any plans to move to Maven or Krysalis for the building. Michael> Although you do have a nice setup already. And I'm quite satisfied with it. So it depends wether the current process can be integrated into Maven whatever or I would have to apply many changes. I like the docbook way of things and don't want to learn just another idiom to provide some project documentation. Otherwise, Maven looks very promising. -- Best regards, Marco |
From: Michael M. <gh...@xt...> - 2002-10-15 21:47:16
|
Kewl. You will have to make changes for maven so probably dont want to go there. Maybe once maven gets a little more mature it would be easier. The key to maven is that you dont really have to learn much...just drop your code into the structure and it goes. Im doing some major refactoring at work, so ill have lots of Maven nous. Ill see if its possible to make the current structure for Jalopy fit into maven. I think it will with a super POM and sub POM's for all the plugins. Although i have to admit the current setup was very easy to get it up and running. I noticed that junit was there but didnt see any tests...are they coming or is that a pipedream. As I want things that arent there ill submit patches so if you could keep CVS update to date, I wont have to duplicate things you've done, and can do other things. :-D cheers Michael On Wednesday, 16 October, 2002 00:02, Marco Hunsicker wrote: > Hello Michael, > > Michael> 1) The implements value is indented improperly in CVS > > Michael> eg > > Michael> public class Wiggles > Michael> extends Foo > Michael> implements Fooable { > > Michael> when it should be > Michael> public class Wiggles > Michael> extends Foo > Michael> implements Fooable { > > I'll look at it, but I think my dev-version does it right (I will > commit changes soon) > > > Michael> 2) get an index out of bounds when printing an array > Michael> initialiser like this: (trys to access markers.getLast() > Michael> when there isnt one) > > Yep, showed up during my testing a few weeks ago. Already fixed on my > drive. But I'll look at your patch anyway. Maybe it is better. > > > Michael> 3) Praise :-D > Michael> It took me a little while to get my head around the source, > Michael> but I have to say its all very well done. > Michael> Good work. > > We're making our way to a first stable version. 1.0b9 will be a *big* > improvement as a german insurance company was willing to do *much* > field testing. > > > Michael> Any plans to move to Maven or Krysalis for the building. > Michael> Although you do have a nice setup already. > > And I'm quite satisfied with it. So it depends wether the current > process can be integrated into Maven whatever or I would have to apply > many changes. I like the docbook way of things and don't want to learn > just another idiom to provide some project documentation. Otherwise, > Maven looks very promising. -- Michael McCallum Software Engineer SnapHire Inc. http://www.SnapHire.com/ |
From: Marco H. <dev...@hu...> - 2002-10-16 09:58:54
|
Hello Michael, Michael> You will have to make changes for maven so probably dont want Michael> to go there. Michael> Maybe once maven gets a little more mature it would be easier. Michael> The key to maven is that you dont really have to learn Michael> much...just drop your code Michael> into the structure and it goes. As always: you may don't have to learn much in the first place if you can live with the way the tool works or its authors want it to work. But if you have special needs, you may soon having a hard time to adapt. Michael> Im doing some major refactoring at work, so ill have lots of Michael> Maven nous. Ill see if its possible to make the current Michael> structure for Jalopy fit into maven. I think it will with a Michael> super POM and sub POM's for all the plugins. Cool. Please keep me up to date. Michael> Although i have to admit the current setup was very easy to Michael> get it up and running. My "build system" was inspired by the NetBeans one. I like the idea to have one central place/module to control the whole process. I need to document the build.properties file better, but besides that everything should be fairly easy to get up and running. Michael> I noticed that junit was there but didnt see any tests...are Michael> they coming or is that a pipedream. Well, writing unit tests is no fun and Jalopy is mainly about having fun. But especially for the printing stuff, the lack of a test suite sometimes drives me mad. And especially for the printing stuff, coming up with an easy way to implement unit tests is very complicated. As always, all additions welcome :) Michael> As I want things that arent there ill submit patches so if Michael> you could keep CVS update to date, I wont have to duplicate Michael> things you've done, and can do other things. :-D Well, I try. As it is, my resources are fairly limited and I have to avoid spending too much time online. For the time being, you can savely use the list to first tell about your ideas and I'm sure we will find a way to avoid duplicate work ;) -- Best regards, Marco |
From: Michael M. <gh...@xt...> - 2002-10-16 04:19:19
|
I was thinking it would be nicer to use CRC's rather than timestamps (or perhaps in conjunction with). Are you planning anything like this or shall i forge ahead and make some patches... Id also like to make it possible to not overwrite the file if the result of formatting was the same as the original regardless of whether it "supposedly" dirty. I was thinking that it would be simple to print the tree to a buffer and calculate the CRC on the fly then compare that with the CRC of the original... if they are the same do nothing. If they are different then do backups etc and write the file. Michael -- Michael McCallum Software Engineer SnapHire Inc. http://www.SnapHire.com/ |
From: Marco H. <dev...@hu...> - 2002-10-16 09:58:58
|
Hello Michael, Michael> I was thinking it would be nicer to use CRC's rather than Michael> timestamps (or perhaps in conjunction with). Are you planning Michael> anything like this or shall i forge ahead and make some patches... You mean for the history feature? Sure. But please wait another day or two until I've committed my latest changes. I'll drop you a note. Michael> Id also like to make it possible to not overwrite the file if Michael> the result of formatting was the same as the original Michael> regardless of whether it "supposedly" dirty. Michael> I was thinking that it would be simple to print the tree to a Michael> buffer and calculate the CRC on the fly then Michael> compare that with the CRC of the original... if they are the Michael> same do nothing. If they are different then do Michael> backups etc and write the file. You need to change the print(JavaNode, String, FileFormat) method in Jalopy.java. Currently the backups are created before a file is "printed", in order to be able to restore the original in case something goes wrong. Just move the logic beyond the printing process and instead of creating a NodeWriter for the specified output target, write output to a buffer first, apply your comparison stuff and only then use the output target. -- Best regards, Marco |
From: Michael M. <gh...@xt...> - 2002-10-16 21:45:32
|
No problems :-) Already looked at it and thats pretty much what i had decided :-D On Wednesday, 16 October, 2002 22:58, Marco Hunsicker wrote: > Hello Michael, > > Michael> I was thinking it would be nicer to use CRC's rather than > Michael> timestamps (or perhaps in conjunction with). Are you planning > Michael> anything like this or shall i forge ahead and make some patches... > > You mean for the history feature? Sure. But please wait another day or > two until I've committed my latest changes. I'll drop you a note. > > Michael> Id also like to make it possible to not overwrite the file if > Michael> the result of formatting was the same as the original > Michael> regardless of whether it "supposedly" dirty. > > Michael> I was thinking that it would be simple to print the tree to a > Michael> buffer and calculate the CRC on the fly then > Michael> compare that with the CRC of the original... if they are the > Michael> same do nothing. If they are different then do > Michael> backups etc and write the file. > > You need to change the print(JavaNode, String, FileFormat) method in > Jalopy.java. Currently the backups are created before a file is > "printed", in order to be able to restore the original in case > something goes wrong. Just move the logic beyond the printing process > and instead of creating a NodeWriter for the specified output target, > write output to a buffer first, apply your comparison stuff and only > then use the output target. -- Michael McCallum Software Engineer SnapHire Inc. http://www.SnapHire.com/ |
From: Marco H. <dev...@hu...> - 2002-10-17 11:26:46
|
Hello Michael, Michael> No problems :-) Michael> Already looked at it and thats pretty much what i had decided :-D I'm not sure whether the new scheme will slow things down. It would be cool to make some measuring and in case of a major slowdown, implement the new scheme as a configurable option to let users choose between security and speed. -- Best regards, Marco |
From: Michael M. <gh...@xt...> - 2002-10-18 01:51:17
|
Thats what i was planning. I dont actually think it will take too much longer because in the end you do a lot less IO so it should be quicker. But i guess well see :-D On Friday, 18 October, 2002 00:26, Marco Hunsicker wrote: > Hello Michael, > > Michael> No problems :-) > Michael> Already looked at it and thats pretty much what i had decided :-D > > I'm not sure whether the new scheme will slow things down. It would be > cool to make some measuring and in case of a major slowdown, implement > the new scheme as a configurable option to let users choose between > security and speed. -- Michael McCallum Software Engineer SnapHire Inc. http://www.SnapHire.com/ |
From: Michael M. <gh...@xt...> - 2002-10-18 17:20:30
Attachments:
checksum.patch
|
Hi Marco, heres the crc code... I left the default as timestamp. Added the settings to the preferences dialog to choose between Timestamp, Crc32 and Adler32 checksums. Added some docs. Updated ant plugin (and tested on ant 1.3 i know i know, didnt want to update my scripts when im moving to maven and i made some major changed to the ant i use :-D ) The formatting may be inconsistent in places. (All my prefs are wildly different than yours :-) And theres no targets to format the source according to the project prefs... Its a little bit slower but for the benefits i think well worth it. I might see if there are anyother algorithms that might be faster around. But CRC's are pretty simple and quick. :-| The defined encoding needs to be used although i guess it wont matter for calculating checksums. (or will it) I think thats all. (there was the duplicated declaration of node in some of the inspector stuff... but youve probably got that already). cheers Michael On Friday, 18 October, 2002 00:26, Marco Hunsicker wrote: > Hello Michael, > > Michael> No problems :-) > Michael> Already looked at it and thats pretty much what i had decided :-D > > I'm not sure whether the new scheme will slow things down. It would be > cool to make some measuring and in case of a major slowdown, implement > the new scheme as a configurable option to let users choose between > security and speed. -- Michael McCallum Software Engineer SnapHire Inc. http://www.SnapHire.com/ |
From: Marco H. <dev...@hu...> - 2002-10-24 17:12:38
|
Hello Michael, sorry for the delay... Michael> Added the settings to the preferences dialog to choose Michael> between Timestamp, Crc32 and Adler32 checksums. Michael> Added some docs. Many thanks. Especially for the docu. But are you sure the patch contains all changes? I thought you had to touch Jalopy.java as well... And the settings dialog threw an exception because the default setting for the method (.toString() instead of .getName() was used). As of today, I've only added the CRC related code. The Ant stuff will follow. And for the printer things, well, please test current HEAD! Michael> The formatting may be inconsistent in places. (All my prefs Michael> are wildly different than yours :-) Thankfully, I don't have to care anymore :) Michael> And theres no targets to format the source according to the Michael> project prefs... There are. But I did not add descriptions so it's not that obvious. Look for "main-format" and friends Michael> Its a little bit slower but for the benefits i think well Michael> worth it. I might see if there are anyother algorithms that Michael> might be faster around. But CRC's are pretty simple and Michael> quick. :-| Yep, that's what I thought. But speed shouldn't matter that much anyway. Michael> The defined encoding needs to be used although i guess it Michael> wont matter for calculating checksums. (or will it) We will see ;) Michael> I think thats all. (there was the duplicated declaration of Michael> node in some of the inspector stuff... but youve probably Michael> got that already). Nope. I haven't worked at that part in ages. What's the matter? I finally managed to commit my latest efforts back to CVS. You should report against this version. Thanks again. -- Best regards, Marco |
From: Michael M. <gh...@xt...> - 2002-10-27 07:43:40
|
doh dont know how i missed Jalopy.java in that patch.. ill make another one tomorrow. |
From: Michael M. <gh...@xt...> - 2002-10-28 09:21:12
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 ok now the patch is sweet against the latests source... there is a bug thats not of my making (at least i dont think so ) but didnt have the time to understand why... just trying to run main-format /home/michael/src/jalopy/main/src/java/de/hunsicker/io/ExtensionFilter.java:0:0:String index out of range: -4 java.lang.StringIndexOutOfBoundsException: String index out of range: -4 at java.lang.String.<init>(String.java:246) at de.hunsicker.jalopy.printer.NodeWriter.generateIndentString(NodeWriter.java:876) at de.hunsicker.jalopy.printer.NodeWriter.print(NodeWriter.java:529) at de.hunsicker.jalopy.printer.NodeWriter.printLeftBrace(NodeWriter.java:676) at de.hunsicker.jalopy.printer.BlockPrinter.printLeftBrace(BlockPrinter.java:761) at de.hunsicker.jalopy.printer.BlockPrinter.print(BlockPrinter.java:343) at de.hunsicker.jalopy.printer.ClassDeclarationPrinter.print(ClassDeclarationPrinter.java:92) at de.hunsicker.jalopy.printer.JavaPrinter.print(JavaPrinter.java:112) at de.hunsicker.jalopy.Jalopy.print(Jalopy.java:2277) at de.hunsicker.jalopy.Jalopy.format(Jalopy.java:1473) at de.hunsicker.jalopy.Jalopy.format(Jalopy.java:1092) at de.hunsicker.jalopy.plugin.ant.AntPlugin.formatSingleThreaded(AntPlugin.java:956) have fun Michael -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE9vQExgC5sbC9WZogRAhdyAJ9h6HBcvfAPztpKgmTpH/Y3qQ2h3gCeJ5Gh HlMubQyF2txFsxeszCZq/t4= =O5oG -----END PGP SIGNATURE----- |
From: Marco H. <dev...@hu...> - 2002-10-30 17:15:39
|
Hello Michael, Michael> ok now the patch is sweet against the latests source... But I'm having problems in using patch (under Windows), grr.... What is the reason that you read files line-by-line instead of just read the whole stream of bytes and calc the checksum? The use of System.getProperty("line.separator") may lead to wrong results here as there is no garantuee that files are actually use the system separator! Michael> there is a bug thats not of my making (at least i dont think Michael> so ) but didnt have the time to understand why... Michael> just trying to run main-format Would you mind submitting your preferences (as .xml)? As I formatted the whole thing before CVS commit, this must have to do with your settings. Thanks. -- Best regards, Marco |
From: Michael M. <gh...@xt...> - 2002-10-31 05:11:13
|
cant remember why i read it line by line... ill get back to you... im on holiday at the moment so it wont be till next week. there probably wasnt a good reason given that i cant remember it. does main-format use my settings? why not put some into the source so that it will always format to the projects preferences.... On Thursday, 31 October, 2002 06:14, Marco Hunsicker wrote: > Hello Michael, > > Michael> ok now the patch is sweet against the latests source... > > But I'm having problems in using patch (under Windows), grr.... > > What is the reason that you read files line-by-line instead of just > read the whole stream of bytes and calc the checksum? The use of > System.getProperty("line.separator") may lead to wrong results here as > there is no garantuee that files are actually use the system > separator! > > Michael> there is a bug thats not of my making (at least i dont think > Michael> so ) but didnt have the time to understand why... > Michael> just trying to run main-format > > Would you mind submitting your preferences (as .xml)? As I formatted > the whole thing before CVS commit, this must have to do with your > settings. Thanks. cheers Michael -- Michael McCallum Software Engineer SnapHire Inc. http://www.SnapHire.com/ |
From: Marco H. <dev...@hu...> - 2002-11-01 11:22:46
|
Hello Michael, Michael> cant remember why i read it line by line... ill get back to Michael> you... im on holiday at the moment so it wont be till next week. Michael> there probably wasnt a good reason given that i cant remember it. I've changed it already. Plus I had to make additional changes because if the history was disabled, your code executed none the less because of the logic to determine its necessity. There is now a method isChecksum() that checks whether the checksum comparison should be performed. Otherwise everything seems to work just fine. Many thanks. This feature really helps. Michael> does main-format use my settings? why not put some into the Michael> source so that it will always format to the projects preferences.... No, it uses mine. And yes, these are contained in the trunk under main/src/resources/jal-bsd.xml Still... >> Would you mind submitting your preferences (as .xml)? As I formatted >> the whole thing before CVS commit, this must have to do with your >> settings. Thanks. -- Best regards, Marco |
From: Peter v. d. W. <p.v...@pl...> - 2002-11-01 12:04:57
|
Marco, When can we expect the next (beta) release. Peter |
From: Marco H. <dev...@hu...> - 2002-11-07 11:23:00
|
Hello Peter, Peter> When can we expect the next (beta) release. Friday or Saturday. -- Best regards, Marco |
From: Michael M. <gh...@xt...> - 2002-11-06 00:07:46
Attachments:
jalopy-1.0-9b.xml
|
Excellent. Heres my prefs... well as close to the ones id like as i can argue it :-D. So if the project uses your settings how would mine affect it? I did do anyformatting except to try run main-format...which failed the the previously mentioned error. No matter, ive been away for a week or so but will get the lastest source and scratch some more itches. cheers Michael On Thursday, 31 October, 2002 23:56, Marco Hunsicker wrote: > Hello Michael, > > Michael> cant remember why i read it line by line... ill get back to > Michael> you... im on holiday at the moment so it wont be till next week. > Michael> there probably wasnt a good reason given that i cant remember it. > > I've changed it already. Plus I had to make additional changes because if > the history was disabled, your code executed none the less because of > the logic to determine its necessity. There is now a method > isChecksum() that checks whether the checksum comparison should be > performed. Otherwise everything seems to work just fine. Many thanks. > This feature really helps. > > > Michael> does main-format use my settings? why not put some into the > Michael> source so that it will always format to the projects > preferences.... > > No, it uses mine. And yes, these are contained in the trunk under > main/src/resources/jal-bsd.xml > > Still... > > >> Would you mind submitting your preferences (as .xml)? As I formatted > >> the whole thing before CVS commit, this must have to do with your > >> settings. Thanks. -- Michael McCallum Software Engineer SnapHire Inc. http://www.SnapHire.com/ |
From: Michael M. <gh...@xt...> - 2002-11-06 01:44:42
|
Brain still on holiday... "i didnt do any formatting except for running main-format!" :-D On Wednesday, 06 November, 2002 13:06, Michael McCallum wrote: > Excellent. > > Heres my prefs... well as close to the ones id like as i can argue it :-D. > > So if the project uses your settings how would mine affect it? > I did do anyformatting except to try run main-format...which failed the the > previously mentioned error. > > No matter, ive been away for a week or so but will get the lastest source > and scratch some more itches. > > cheers > > Michael > > On Thursday, 31 October, 2002 23:56, Marco Hunsicker wrote: > > Hello Michael, > > > > Michael> cant remember why i read it line by line... ill get back to > > Michael> you... im on holiday at the moment so it wont be till next week. > > Michael> there probably wasnt a good reason given that i cant remember > > it. > > > > I've changed it already. Plus I had to make additional changes because if > > the history was disabled, your code executed none the less because of > > the logic to determine its necessity. There is now a method > > isChecksum() that checks whether the checksum comparison should be > > performed. Otherwise everything seems to work just fine. Many thanks. > > This feature really helps. > > > > > > Michael> does main-format use my settings? why not put some into the > > Michael> source so that it will always format to the projects > > preferences.... > > > > No, it uses mine. And yes, these are contained in the trunk under > > main/src/resources/jal-bsd.xml > > > > Still... > > > > >> Would you mind submitting your preferences (as .xml)? As I formatted > > >> the whole thing before CVS commit, this must have to do with your > > >> settings. Thanks. -- Michael McCallum Software Engineer SnapHire Inc. http://www.SnapHire.com/ |
From: Marco H. <dev...@hu...> - 2002-11-12 23:05:08
|
Hello Michael, Michael> So if the project uses your settings how would mine affect it? Well, it can always be that a certain settings combination does not work. Remember that I don't have unit tests and only test behavior for two orthogonal styles. Michael> I did do anyformatting except to try run main-format...which Michael> failed the the previously mentioned error. I've testet it and it went fine. Maybe CVS wasn't up-to-date then or I applied some magical changes since??? I have no idea. -- Best regards, Marco |