Re: [Jajuk-dev] Upgrade of jaudiotagger and xstream and more
Your Advanced jukebox
Brought to you by:
bflorat
From: Bertrand F. <ber...@fl...> - 2017-11-27 21:37:11
|
On 26/11/2017 10:33, Gwen K wrote: > Hi Bertrand, Hi Gwen, > > 1) I pushed a commit on develop to upgrade jaudiotagger (I dit it on feature/html too) and also for xstream. > With xstream on java 9, I encountered warning on deprecated code. Fine. Are both libs related ? If not, don't hesitate to drop xsteam entirely, it's a very old and messy library. > > 2) I prepare also corrections for lyrics because lyrics web sites moved to https or they changed the HTML content, Jajuk doesn't get lyrics anymore. > Fine > Do you you think It's worth to create a lyrics branch ? > I suggest you to use private branch on your computer and to merge/rebase them into the develop branch before pushing. I made an exception for the feature/html but it was only to make it easier to show you. I dropped it. > 3) I have some warnings on startup (didn't investigate) : > WARNING: An illegal reflective access operation has occurred > WARNING: Illegal reflective access by org.jajuk.services.players.AbstractMPlayerImpl (file:/home/gwen/workspaceoxygen/jajuk/bin/) to field > java.lang.ProcessImpl.pid > WARNING: Please consider reporting this to the maintainers of org.jajuk.services.players.AbstractMPlayerImpl > WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations > WARNING: All illegal access operations will be denied in a future release Yes, I saw that. This is because you access a private field of Process class to get the mplayer PID. In Java 9, there is now a proper way to get it (long Process.getPID() ) but we can't use it because we have to ensure Java 8 runtime support. AFAIK, we have to stick with the WARNING (or set the --ilegal=warn option) until we support Java 9 +. Let me know if you see another way. BTW : please make sure to send your e-mails to the dev mailing list (I CC it) so everybody can get the information and it is archived. > > Cheers, > Cheers, Bertrand > Gwen. -- _________________________________ Bertrand FLORAT http://www.florat.net PGP : http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xFF60EFCB18BFF8B7 Try Jajuk Advanced jukebox (http://jajuk.info) __________________________________ |