Menu
▾
▴
Re: [Jajuk-dev] Regression on the history bar
|
From: Bertrand F. <ber...@fl...> - 2009-04-26 13:54:49
|
Dominik Stadler wrote: > Hi, > Hi, > thanks for the note, yes, sorry, seems I broke that code with these type of changes. I have reverted them for now to what it was before. Can we configure the Sonar reports to not show these items as we should not change them in some cases? > As you which, your sonar changes were perfectly righteous through but it is perhaps difficult to conciliate both concerns. On sonar : no, the coding rules profiles are set once for all by the Sonar team as we use an hosted version of Sonar (it comes with many benefits to use an hosted version and not an installed one). > Please note that I also checked in two more changes that reduce the number of instantiated IconLabel items from around 50k down to a few hundred for my 17k collection by reusing the objects in the various models so that each model only uses 2 instances at most. For the Stars we also have to consider the rating as it is used as popup. In order to do this I now hold a cache of Stars together with their rating so we can reuse them. > Alright. Honestly, I didn't implement this because I was wondering if a single widget can be realized several times in Swing but it looks like. It's a good optimization. Even if the memory gain is not huge due to raw java image caching, it can only be good to reduce number of object to garbage collect or manage. > It seems this does not lead to a big memory gain, but a small reduction should be possible through this. I think the actual icons do either reuse things like Strings internally already or do not hold much information themselves... > > Let me know if you see any problem caused by this small optimization. The only possible downside I see is that the cache is not cleaned out and thus could fill up if somebody adjusts ratings a lot, however it is still limited to the number of different ratings that are used, so it will not grow endlessly and still will be much smaller than the number of items we held before. > OK, keep things as simple as possible for now (KISS ;--) ) > Thanks... Dominik. > > -------- Original-Nachricht -------- > >> Datum: Sat, 25 Apr 2009 15:35:12 +0200 >> Von: Bertrand Florat <ber...@fl...> >> An: Jajuk developers list <jaj...@li...> >> Betreff: [Jajuk-dev] Regression on the history bar >> > > >> Hi Dominik, >> >> Seems that there is a regression on the history bar (in command panel). >> New tracks doesn't update the combobox. I think I know why : the combo >> use a vector as a model (in the MVC meaning) and you changed the vector >> stored in History class to an arraylist to meet current coding standards >> and you instanciate the combo with a new Vector(of the arraylist) so it >> is a shallow copy of the initial list and this list is no more updated. >> >> Could you please have a look on it ? >> >> Thanks, >> >> - Bertrand >> >> -- >> Bertrand FLORAT >> ber...@fl... >> http://www.florat.net >> Chat: bf...@ja... >> PGP keyserver: pgp.mit.edu >> Try Jajuk Advanced jukebox (http://jajuk.info) >> >> >> ------------------------------------------------------------------------------ >> Crystal Reports - New Free Runtime and 30 Day Trial >> Check out the new simplified licensign option that enables unlimited >> royalty-free distribution of the report engine for externally facing >> server and web deployment. >> http://p.sf.net/sfu/businessobjects >> _______________________________________________ >> Jajuk-developers mailing list >> Jaj...@li... >> https://lists.sourceforge.net/lists/listinfo/jajuk-developers >> > > -- Bertrand FLORAT ber...@fl... http://www.florat.net Chat: bf...@ja... PGP keyserver: pgp.mit.edu Try Jajuk Advanced jukebox (http://jajuk.info) |