[Jadclipse-develop] [ jadclipse-Bugs-1479934 ] Double click on editor ruler doesn't add breakpoint

[SourceForge.net <no...@so...>]

Bugs item #1479934, was opened at 2006-05-01 18:40
Message generated for change (Comment added) made by jgyger
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=427342&aid=1479934&group_id=40205

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Works For Me
Priority: 5
Private: No
Submitted By: Andrei Loskutov (andyandy)
>Assigned to: Johann Gyger (jgyger)
Summary: Double click on editor ruler doesn't add breakpoint

Initial Comment:
In the case if Jadclipse is installed and set as 
default editor for class files, then the class files 
*with attached source* have strange problem: double 
click  on editor ruler doesn't add a breakpoint. I have 
long time assumed that this was an Eclipse bug, but 
since I use Linux (and Jadclipse is therefore not 
installed) I have never seen this error again.
After looking in the code, I have discovered, that the 
followed code in JadclipseBreakpointRulerActionDelegate 
is responsible for the error:

        // only care about jadclipse class file editor
        if (targetEditor != null) {
            String id= targetEditor.getSite().getId();
            if (!id.equals(JadclipseClassFileEditor.ID
))
                targetEditor= null;
        }

I don't understand why is it required to create own 
JadclipseBreakpointRulerActionDelegate class, but at 
least in Eclipse 3.2 it seems not to be required 
anymore.

As a workaround/patch for the described problem one 
could simply change plugin.xml from Jadclipse and use 
default RulerToggleBreakpointActionDelegate class 
instead:

   <extension
         point="org.eclipse.ui.editorActions">
      <editorContribution
            targetID="jadclipse.
JadclipseClassFileEditor"
            id="jadclipse.JadclipseClassFileEditor.
BreakpointRulerActions">
         <action
               label="?"
               class="org.eclipse.debug.ui.actions.
RulerToggleBreakpointActionDelegate"
               actionID="RulerDoubleClick"
               id="jadclipse.
ManageBreakpointRulerAction">
         </action>
      </editorContribution>
   </extension>

----------------------------------------------------------------------

>Comment By: Johann Gyger (jgyger)
Date: 2006-10-24 20:09

Message:
Logged In: YES 
user_id=7927

Works for Eclipse 3.2

----------------------------------------------------------------------

Comment By: Andrei Loskutov (andyandy)
Date: 2006-05-21 17:50

Message:
Logged In: YES 
user_id=224122

I have tested with the latest 3.1 version. I haven't tried 
3.2 version yet.

----------------------------------------------------------------------

Comment By: Johann Gyger (jgyger)
Date: 2006-05-21 17:43

Message:
Logged In: YES 
user_id=7927

Andrei,

Thanks for your suggestions. I think this is already fixed
the way you proposed. Did you have a look at the right
source? The source for Eclipse 3.2 is on a CVS branch
(Eclipse_3_2_Branch). Which version of JadClipse and Eclipse
are you using exactly? Does the problem still occur with
JadClipse 3.2.2 and Eclipse 3.2?

- Johann

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=427342&aid=1479934&group_id=40205