#28 Change from PDF to PDFS prevents dotting (serious issue!)
The latest change from PDF to PDFS created a serious problem for the current HB2016 conference since we can not set any paper status that requires a PDF file upload.
I think I already know what the problem might be, and will explain it here:
This change set the PDF_file$ constant from PDF to PDFS:
https://sourceforge.net/p/jacow-spms/code/ci/9f98ca278a8b6d06bb620bf0269dcfc8fd0046a0/
The constant 'PDF_file$' that is now set to 'PDFS' is used in the cursor in 'common.pdf_uploaded' and is concatenated with a paper code to create the full filename.
So SPMS instead of e.g. searching for 'MOAM5P50.PDF' tries to find a file with the name 'MOAM5P50.PDFS' which does not exist since the file uploaded through the upload scripts was 'MOAM5P50.PDF'.
The check takes place around line 4216 in Common.sql:
function pdf_uploaded (abs_id integer) return boolean is
cursor driver is
select 1
from files
where abstract_id = abs_id
and upper(file_name) =
( select upper(paper_id) || '.' || pdf_file$
from abstract_sessions
where abstract_id = abs_id
and primary_flag = 'Y'
);
I am not sure what the correct procedure is, but since PDFS is not a file extension but a 'file type' in SPMS maybe something like a second constant 'PDF_file_extension$ := PDF' should be introduced?
