#7 ConnectionBean: fixes and cleanups

[Neil Conway]

This patch fixes the following issues with
ConnectionBean.java, v1.30:

1) Minor javadoc cleanups throughout

2) Minor code formatting cleanups

3) Remove the pointless (?) calls to super() in the
constructors for 2 of the inner classes

4) Remove redundant calls to setConnecting() in the
connect(*) methods. Now setConnecting() should be
called once for every external connect(*) call

Not too exciting. With the exception of #3, this is
just regular stuff. I think the changes in #3 are
right, but your opinion would be appreciated.

The patch against current CVS is attached in context
diff format.

[Neil Conway]

Context diff, v1.0

[David Waite]

Logged In: YES
user_id=9752

Patch 1.0 applied, but I removed the parts of the patch
relating to setConnecting().

[Neil Conway]

Logged In: YES
user_id=11779

Is there a reason why the setConnecting() stuff was removed?
AFAICT, it's been called more times than are necessary
(there is logic in the method to handle this redundancy, but
I'd prefer the extra calls not be made in the first place).

[David Waite]

Logged In: YES
user_id=9752

Right now the 'connecting' event is supposed to be fired as
soon as the connect method is called. It should be
'connecting' from when the remote machine is first connected
to, debatably from when the DNS lookup by INetAddress is
performed.

If what connecting means is defined better, it can move
later in the chain. It might help if some of those
connection routines were unchained as well.