Josh Hansen - 2013-05-02

Patch against r54.

  • Fixed bug in ModbusTCPListener where worker threads could not be shutdown:
    * Replaced ThreadPool with ExecutorService. Relies on Java 1.5.
    * ExecutorService (and threads) are created and removed along
    with socket listening in run().
    * ThreadPool is now obsolete within the project.

  • Modified ModbusTCPListener thread naming
    * Parent and worker threads are given default names.
    * Parent thread name can be overridden.

  • Modified ModbusTCPListener start()
    * Now has comment indicating that "listen()" should be used
    instead.
    * Calls listen()

  • Fixed NullPointerException in ModbusTCPListener stop().
    * If listen() was used instead of start(), it is now safe to
    call stop() to close the socket.

Josh

EDIT: Removed signature.
EDIT: Added attachment

 

Last edit: Josh Hansen 2013-05-02
patch-20130502.diff