#7 Default User Assignment; Optional Comment
*** Changes ****
There are two changes here. One of them requires a table structure addition to the table 'spaces'; the other is code-only.
** Default User Assignment
After an item status change on the ItemViewFormPanel, this update confirms that the currently assigned user is available in the filtered user list; and if that user is available, sets them to be the default 'assigned to' selection on status change. If that user is not available, the field remains blank by using default (existing) behavior.
** Optional Comment:
Added a new Space-level setting, "comment required on change". Defaults to 'true' for backward compatibility. If this is false, the "comment" field on the ItemViewFormPanel is not set to required. If it is true, that field is set to required (as it is in current code.)
SQL required:
ALTER TABLE <SCHEMA>.spaces ADD COLUMN comment_required INTEGER DEFAULT 1
**** Testing ****
I have tested the following scenarios with these changes:
Default User Assignment
1. assigned item to a user that did not have assigned the role required for item state of "Closed". CHange item status to "Closed". Result: assigned user field blanked out, required to choose another user.
2. Same item above, changed item state to "Open". Current assignee did have correct role to allow assignment. Result: upon population, assigned user field selection was defaulted to the item's currently assigned user.
3. Repeated test 1, without saving change from test 2. Ensured that the assigned user selection was cleared.
Optional Comments
1. With comment required = true, submitted a change to an item without providing a comment. Correctly flagged as an error
2. With comment required = true, submitted a change to an item and provided a comment. Correctly allowed this change and saved comment.
3. With comment required = false, submitted a change to an item and did not provide a comment. Correctly accepted this value, and defaulted to a blank comment.
4. With comment required = false, submitted a change to an item and did provide a comment. Correctly allowed this change and saved comment.
In addition, I have put these changes through several hours of 'real world' testing by using them in my own jtrac distribution.
** Attachments:
jtrac-diff.zip : svn diff of changed files
jtrac-modified.zip : full source of changed files, within source tree.
Logged In: YES
user_id=311454
Originator: YES
File Added: jtrac-modified.zip
Logged In: YES
user_id=311454
Originator: YES
Oops - uploaded an older version. Deleting and reattaching correct version of both files
Full source version of modified files.
Logged In: YES
user_id=311454
Originator: YES
File Added: jtrac-modified.zip
Logged In: YES
user_id=311454
Originator: YES
File Added: jtrac-diff.zip
Diff patches for all changes.
Logged In: NO
Any chance of these changes getting included?
Logged In: NO
Is there a chance that this will be included?