#20 Parameters broken with saa7127 + modprobe + linux 2.6.x

[Anonymous]

Hej!

Just found a little glitch in v. 0.2.0.rc3i:

On linux kernels > 2.6.x, there is a mix of
MODULE_PARAM() and module_param() in saa7127.c which
causes

a) a harmless message:

saa7127: Ignoring new-style parameters in presence of
obsolete ones

b) the module not to know the debug and test_image
parameters.

saa7127: Unknown parameter `test_image'

The following patch fixes the problem (but I don't know
how to tell the macro about the size of the array)

[root@frustburg driver]# diff -c saa7127.c.orig saa7127.c
*** saa7127.c.orig Sat Apr 30 20:47:50 2005
--- saa7127.c Sat Apr 30 20:57:13 2005
***************
*** 122,128 ****
--- 122,132 ----

/* Default to all active */
static int i2c_enable[IVTV_MAX_CARDS] = { 1, 1, 1, 1,
1, 1, 1, 1 };
+ #if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 0)
+ module_param_array(i2c_enable, int, NULL, 0644);
+ #else
MODULE_PARM(i2c_enable, "1-"
__stringify(IVTV_MAX_CARDS) "i");
+ #endif
MODULE_PARM_DESC(i2c_enable, "which 150/350 cards to
activate the saa7127, conflicts with cx25840 or pvr150");

/*

[Quite unfortunately, I still get no output from the
second PVR 350 card I just bought, not even a test
image, while the other one works fine]

Greetings from Vienna,

Alexander Talos <at@atat.at>