RE: Changes to ivtools-drawtool
Brought to you by:
johnston
|
From: Glen K. <gl...@mi...> - 2002-02-08 13:37:43
|
> Two comments about work so far: 1) feel free to do generic work > like this in place, in the existing methods and classes (I do understand this was > just an initial experiment); The reason I put the code in a new file was that I thought that the OverlayUnidraw API was a completely separate project, like Unidraw. Are there any guidelines as to what source can be modified and what can't? > 2) I like the double row of toolbar buttons, but it > certainly begs for some mechanism to preserve a natural height to the entire toolbar > panel(to preserve the natural shape of the drawing editor, whatever that would be). I am not sure what you mean by "natural height". I have been working on trying to make the program choose the appropriate number of columns for the toolbar based on the window size (ie. as the window's height increases, fewer columns are needed for the tool buttons). If you have any hints on how to detect changes in window size that would help. I've tried using the Observer/Observable interface via: GetEditor()->GetOverlayViewer()->GetOverlayView()->GetOverlayComp()->attach( new MyObserver), but it doesn't seem to detect size changes, just drawing events. > As for submitting work, you have two choices: via cvs with developer permissions > (which I will give you shortly), or via informal patches e-mailed to > ivt...@li.... If you choose to use patch I will keep > the cvs repository in synch myself. If you use cvs it would be helpful if you sent > an e-mail to ivt...@li... after committing a set of changes > that will go into a formal patch. There is an automatic notification of commits >but a redundant notice will help me keep things organized (and inform others > of progress). OK, I will submit my preliminary changes to CVS some time today. |