#98 Test that `resetall does not clear macros

closed-accepted
nobody
None
5
2010-12-03
2010-11-28
Joe
No

Hi,
The most trivial of tests!
This is right from the Verilog spec, chapter nineteen section three, and it tests that `resetall does not affect macros.

Discussion

  • Stephen Williams

    It would be nice if this test were updated so that it printed "PASSED" and was integrated into the regress.list. As it stands now, it is a dangling test that is not run.

     
  • Joe

    Joe - 2010-11-28

    macro2 is in regress.list, and it's reported as passing in regression_report-devel.txt :)

    Here's a patch to make it emit "PASSED" and clean up the gold file.

     
  • Joe

    Joe - 2010-11-28

    I should have been more clear - the second patch "0002" goes -after- the first patch "0003"

     
  • Stephen Williams

    Applied to git master.

     
  • Stephen Williams

    • status: open --> closed-accepted
     
  • Stephen Williams

    OK, the numbering was a little bit confusing.

    Also, as a general rule I prefer to not change existing tests and instead add new tests when testing a new feature. The reason for that is that sometimes the existing test is checking a subtlety (that was a bug) that is not at all obvious. Keep that in mind in the future.

     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks