Menu

#3 GCC 3.4.2 compile fixes

open
nobody
None
5
2006-08-24
2006-08-24
No

This patch fixes several warnings and errors that occur
atleast when compiling with MingW GCC 3.4.2, including
such as:

Main/Source/char.cpp:9784: error: extra `;'

Main/Include/miscitem.h:565: error: extra qualification
`gasgrenade::' on member `ReceiveDamage' ignored

Main/Include/trap.h:47: warning: `class itemtrapbase'
has virtual functions but non-virtual destructor

Main/Source/human.cpp:5161: warning: comparison between
signed and unsigned integer expressions

Main/Include/god.h: In constructor `god::god()':
Main/Include/god.h:89: warning: `god::Known' will be
initialized after
Main/Include/god.h:87: warning: `int god::LastPray'
Main/Source/god.cpp:17: warning: when initialized here

Following warnings are still present after changes in
the patch:

In file included from Main/Source/charset.cpp:56:
Main/Source/char.cpp: In member function `void
character::ReceiveSirenSong(character*)':
Main/Source/char.cpp:9814: warning: too few arguments
for format
Main/Include/item.h: At global scope:
Main/Include/item.h:572: warning: unused parameter 'type'
Main/Source/char.cpp:9782: warning: unused parameter
'Enemy'
Main/Source/char.cpp:9782: warning: unused parameter
'Weapon'
Main/Source/char.cpp:9782: warning: unused parameter
'ToHitValue'
Main/Source/char.cpp:9782: warning: unused parameter
'Success'
Main/Source/char.cpp:9782: warning: unused parameter 'Type'
Main/Include/item.h:572: warning: unused parameter 'type'
Main/Source/human.cpp:5115: warning: unused parameter
'Worm'
Main/Include/item.h:572: warning: unused parameter 'type'
Main/Source/game.cpp: In static member function `static
truth game::Init(const c
festring&)':
Main/Source/game.cpp:370: warning: unused variable
'PlayerHasReceivedAllGodsKnow
nBonus'
Main/Include/item.h: At global scope:
Main/Include/item.h:572: warning: unused parameter 'type'
Main/Include/item.h: At global scope:
Main/Include/item.h:572: warning: unused parameter 'type'
In file included from Main/Source/itemset.cpp:51:
Main/Source/bodypart.cpp: In member function `void
bodypart::CalculateMaxHP(ulon
g)':
Main/Source/bodypart.cpp:1345: warning: unused variable
'OldMaxHP'
In file included from Main/Source/itemset.cpp:52:
Main/Source/gear.cpp: In member function `virtual void
acidshield::BlockEffect(c
haracter*, character*, item*, int)':
Main/Source/gear.cpp:1010: warning: unused variable
'CheckAttackType'
Main/Source/gear.cpp: In member function `virtual void
wondersmellstaff::Break(c
haracter*, int)':
Main/Source/gear.cpp:1047: warning: unused variable
'GasMaterial'
Main/Include/item.h: At global scope:
Main/Include/item.h:572: warning: unused parameter 'type'
Main/Source/miscitem.cpp:2784: warning: unused
parameter 'Frame'
Main/Source/miscitem.cpp:2691: warning: unused
parameter 'Damager'
Main/Source/gear.cpp:1009: warning: unused parameter 'Type'
Main/Source/bodypart.cpp:3534: warning: unused
parameter 'SrcID'
Main/Source/bodypart.cpp:3534: warning: unused
parameter 'Amount'
Main/Source/bodypart.cpp:3512: warning: unused
parameter 'Amount'
Main/Source/bodypart.cpp:3436: warning: unused
parameter 'Type'
Main/Include/item.h:572: warning: unused parameter 'type'

Discussion

  • Jaakko Salli

    Jaakko Salli - 2006-08-24

    Logged In: YES
    user_id=1193883

    Converted patch to use UNIX line endings.

     
  • Jaakko Salli

    Jaakko Salli - 2006-08-24
     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.