Support odd powers of two for QAM

Brought to you by: cristeab, ediap, tonyottosson

#73 Support odd powers of two for QAM

Milestone: Next_Release

Status: accepted

Owner: Bogdan Cristea

Labels: itpp (51)

Priority: 5

Updated: 2014-02-22

Created: 2010-09-25

Creator: Kumar Appaiah

Private: No

Hi!

My work requires me to use odd powers of two for the QAM class. However, IT++ does not yet have support for this. Please add support for this.

I have attached a rudimentary patch to get this done. I would be more than happy to adapt it for:

handling checks I may have missed
coding style
tests

Please let me know how I can be of help.

Thanks!

Kumar

Discussion

Kumar Appaiah - 2010-09-25

0002-Add-support-for-rectangular-QAM-for-odd-powers-of-tw.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kumar Appaiah - 2010-10-04

Gentle ping: could someone please review this?

Thanks in advance, and sorry for bugging. :-)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kumar Appaiah - 2011-04-15

Is there any update to this? I've run into this problem again on another machine, and I need to manually patch IT++ to fix it.

This isn't such a difficult patch to review, I'd appreciate it if someone could have a look at it and comment.

Thanks!

Kmar

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Bogdan Cristea - 2013-05-23

Is there any interest in this feature ? I can handle the integration, but I don't have time for implementation details.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kumar Appaiah - 2013-05-23

I am still interested in this, but I might not be able to finish it by the release target date. Given that this is the case, please set this for the next milestone, and not the release you are planning this week.

I'll integrate it as soon as the release is done.

Thanks.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kumar Appaiah - 2014-02-16

Hi.

Please review the attached patches and let me know if they are good enough.

Thanks.

0001-Add-support-for-rectangular-QAM-for-odd-powers-of-tw.patch

0002-Include-a-test-case-for-odd-QAM-powers-32-QAM.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Bogdan Cristea - 2014-02-16

status: open --> accepted

assigned_to: Bogdan Cristea

Group: --> Next_Release
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Bogdan Cristea - 2014-02-16

Changes committed into master branch; Thanks Kumar.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kumar Appaiah - 2014-02-20

I just noticed a minor style issue. I have attached a small patch. Could you please consider it?

Sorry for the trouble! Thanks.

0001-Ensure-that-the-modulator-evergy-calculation-uses-do.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kumar Appaiah - 2014-02-20

Heh. And I misspelt the word energy in the commit. Urgh! Please fix that as well! Thanks.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Bogdan Cristea - 2014-02-22

done

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.