Menu

Problem in pulse_shape

andy
2005-05-16
2012-09-15
  • andy

    andy - 2005-05-16

    Hi,

    I think there is a problem in the pulse-shape class for small roll-off-factors. When calling the function

    template<class T1> void Raised_Cosine<T1>::set_pulse_shape

    in line 333 of pulse_shape.h for a small roll-off-factor, the function might try to access elments of the vector this-&gt;_filter_impulse_response which are out of range causing a segmentation fault. To fix this problem i propose to change line 350 if (is_int(itemp)) to if (is_int(itemp) &amp;&amp; itemp&lt; this-&gt;_filter_impulse_response.size()).

    Best regards,

    Andy

     
    • Adam Piątyszek

      Adam Piątyszek - 2005-05-17

      Dear Andy!

      First of all, when you report a bug or a feature request it would be great if you write the IT++ version you use and the platform on which it is installed. BTW, for bug reports, please use Bugs in the Sourceforge, instead of forums.

      The problem, which you have described, might not exist in the latest sources, which are still in CVS though, since the Pulse_Shape class has been rewritten recently (actually in January 2005).

      If you are using the IT++ library, I encourage you to have a try to the CVS version - a lot of bugs are fixed in CVS, but not yet released as a stable version...

      /ediap

       

Log in to post a comment.