iTop - IT Service Management & CMDB / Tickets / #2045 French characters replaced with HTML encoding on dashlet

#2045 French characters replaced with HTML encoding on dashlet

Milestone: 2.7.7

Status: closed

Owner: Pierre Goiffon

Labels: None

Resolution:

Component: User Interface

Priority: Medium

Version: 3.0.0

Type: defect

Updated: 2022-07-26

Created: 2022-03-10

Creator: Kirushoth Kirubaharan

Private: No

Hello,

I noticed an issue that could be resolved in the next patch. When adding a Header with statistic dashlet, Group by values with French characters appear to be displaying HTML encoding instead (screenshot attached).

After investigating the iTop base code, we noticed that there is a function to encode HTML special characters, which is used twice before output. If we were to remove one of them, it displays the characters correctly.

2 Attachments

French characters replaced with HTML encoding.PNG

friendlynames.PNG

Discussion

Kirushoth Kirubaharan - 2022-03-10

The function is called HtmlEntities which is defined in /application/utils.inc.php. It is then called in /application/displayblock.class.inc.php on line 1048 on a string that was already encoded.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Pierre Goiffon - 2022-03-22

Hello,

We had some bugs like this during the beta.

I see there are no problems on the demo :
https://demo.combodo.com/simple/pages/UI.php
Login admin-fr / admin
Welcome screen
"Gestion des demandes" dashlet

Are you really running iTop 3.0.0 final version on not one of its beta ?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Kirushoth Kirubaharan - 2022-03-22
  
  Hello,
  
  Yes, we are running iTop 3.0.0 final version, which was downloaded from source forge. https://sourceforge.net/projects/itop/files/itop/3.0.0/
  
  Were you able to look into the function is called HtmlEntities, defined in /application/utils.inc.php? It is then called in /application/displayblock.class.inc.php on line 1048 on a string that was already encoded. We noticed that this function will encode HTML special characters, which is used twice before output. If we were to remove one of them, it displays the characters correctly.
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Pierre Goiffon - 2022-03-22

status: new --> more-info-needed

assigned_to: Guillaume Lajarige --> Pierre Goiffon
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Pierre Goiffon - 2022-03-22

Can you provide a mean to reproduce please ?
Using one of the demo instance (https://www.combodo.com/itop-access-to-the-demonstration) if possible ?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Kirushoth Kirubaharan - 2022-03-22
  
  Hello,
  
  I have recreated the issue on your demo instance.
  https://demo.combodo.com/simple/pages/UI.php?auth_user=admin&suggest_pwd=admin
  https://demo.combodo.com/simple/pages/UI.php?operation=details&class=Location&id=7&&a=1#ObjectProperties=tab_UIPropertiesTab
  
  Capture.PNG
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Pierre Goiffon - 2022-03-23

Many thanks, I can now reproduce easily !
I've created a bug in Combodo's internal DB : ~~N°4991~~ N°4538

Last edit: Pierre Goiffon 2022-03-24

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Pierre Goiffon - 2022-03-23

status: more-info-needed --> accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kirushoth Kirubaharan - 2022-05-16

I noticed this issue was not fixed in 3.0.1. Could you provide a date for when we can expect it to be resolved?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Hipska - 2022-05-17
  
  Milestone is "unassigned" and status is not "resolved" yet. So there is no indication it would have been fixed in 3.0.1.
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Pierre Goiffon - 2022-05-17

Hello,
The bug is been working on currently. We will update this ticket when we will publish the version including this fix.
In the meantime you can check regularly the iTop repo log : you will find the internal ref "N°4538" on each corresponding commit log message.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Benjamin DALSASS - 2022-07-26

status: accepted --> closed

Milestone: Unassigned --> 2.7.7
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Benjamin DALSASS - 2022-07-26

Fix iTop 2.7.7 will be delivered next week

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kirushoth Kirubaharan - 2022-07-26

iTop version 2.7.7?

We currently have v3.0.1 installed

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Guillaume Lajarige - 2022-07-26

Fixes from iTop 2.7.7 will be integrated in iTop 3.0.2 which will roll out early autumn.

Cheers,
Guillaume

👍
1

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Vincent @ Combodo - 2022-07-26

It will also be included in 3.0.2 planned for September...

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.