#1213 Not expected random result when updating n:n link

[Bluearrow]

Not expected random result when updating n:n link .
One contract had x different services attached, I updated link customercontract-Services documenting SLA and coverage window.
iTOP erased (x-1) services by the last one and at the end, I have under CustomerContract x identical services attached to this one.
I tried to modify and delete services from customercontract window and it doesn't work (I can select services, click on delete and nothing happened, I still have X identical services).
only way to clean my DB is to go on OQL menu: SELECT lnkCustomerContractToService and here I can delete wrong entries and attach again my wanted services.

[Bluearrow]

you can reproduce issue:
if you change SLA related on one Service from CustomerContract , it's OK
if you change Service related from SLA schema, then you regenerate the issue

[Romain Quetiez]

To reproduce, on a fresh install with sample data:

• Open the "Standard SLA" for modification.
• Remove the last service (Telecom and Connectivity) and save
• Outcome: the SLA now appears to have three identical services (the second one in the original list: Software)

Variations, still starting from fresh sample data:

• Open the "Standard SLA" for modification.
• Remove the first OR the second service (Computers and Peripherals OR Software) and save
• Outcome: the SLA now appears to have three identical services (the third one in the original list: Telecom and Connectivity)

[Romain Quetiez]

One more method to reproduce:

• Fresh install w/sample data
• Edit Standard SLA and simply type something into Description
• Save it... the three contracts exhibit the same service!

[Romain Quetiez]

Fix: allow duplicates for such a link set. This change requires an alteration of the data model:

<classes>
   <class id="SLA">
      <fields>
        <field id="customercontracts_list">
          <duplicates_delta="redefine">true</duplicates>
        </field>
      </fields>
   </class>
</classes>

Analysis: such a linkset is not of the same nature as the linksets between contracts and services: A single SLA can list the same contract several times (for various services), which breaks an assumption on link sets as configured by default. See how the search dialog does not propose the objects already related.

Fix implemented in trunk as [r4109]

This fix raises the exposure of a few limitations documented in [#1145], [#1146] and [#1147], but this does not seem to be problematic when it comes to work with SLAs.

[Romain Quetiez]

Not reproduced on iTop 2.1.0

Reproduced on trunk, HEAD revision.