Menu

#39 Small glitch in parsing 256 colors

open
nobody
None
5
2009-09-30
2009-07-31
wereHamster
No

echo -e "\033[01;38;5;196mred text\033[0m" should show a bold red text (xterm does it correctly), but iTerm shows a bold blinking text. The attached patch should fix it (I didn't test it because I can't figure out how to compile iTerm.

The patch will fix the above command, but I'm not sure what to do in edge cases, like: \033[01;38;5m, the patch will ignore the incomplete 256 color commands and show a blinking text. Maybe it would be better to remove the 'i+=2' and put i += MIN(2, token.u.csi.count - i - 1) outside of the if.

Discussion

  • wereHamster

    wereHamster - 2009-07-31
     
  • James Bunton

    James Bunton - 2009-09-16

    Works for me with the latest svn. Could you please try with this build:
    http://delx.net.au/files/iTerm.app.zip

     
  • James Bunton

    James Bunton - 2009-09-16
    • labels: --> 484351
    • milestone: --> 257198
    • status: open --> pending
     
  • Walter Dörwald

    Walter Dörwald - 2009-09-30

    http://delx.net.au/files/iTerm.app.zip doesn't fix the problem for me.

     
  • James Bunton

    James Bunton - 2009-09-30
    • labels: 484351 -->
    • milestone: 257198 -->
    • status: pending --> open
     

Log in to post a comment.