Menu

#19 Fix Fedora 40 crash caused by LTO

1.6.0
closed-rejected
nobody
None
5
2024-08-12
2024-08-06
No

In Fedora 40, assuming that sync directory starts from an empty state, mbsync will sigsegv unless LTO is disabled.

1 Attachments

Discussion

  • Jarkko Sakkinen

    Jarkko Sakkinen - 2024-08-06

    For more information, see the discussion at https://bugzilla.redhat.com/show_bug.cgi?id=2302132

    When LTO is on boxes array is literally truncated to a single element array. I do not think mbsync will have any particular benefit from LTO so it would really be pragmatic decision to plain disable it also to prevent any future issues happening.

     

    Last edit: Jarkko Sakkinen 2024-08-06
  • Jarkko Sakkinen

    Jarkko Sakkinen - 2024-08-06

    One remark. Now that I re-tested my patch I had to:

    -mbsync_CFLAGS = -fno-lto
    +CFLAGS += -fno-lto
    

    Otherwise:

    drv_proxy.c:458:10: fatal error: drv_proxy.inc: No such file or directory
      458 | #include "drv_proxy.inc"
          |          ^~~~~~~~~~~~~~~
    

    I don't understand this causality so not updating patch yet.

     
  • Jarkko Sakkinen

    Jarkko Sakkinen - 2024-08-06

    Right you can add patch per comment. Well here's v2.

     
  • Oswald Buddenhagen

    i think this is already properly fixed by commit ceb0fa980.

     
  • Jarkko Sakkinen

    Jarkko Sakkinen - 2024-08-12

    OK it does fix the issue. I tested it! I report this to the Fedora bug, thank you.

     
  • Jarkko Sakkinen

    Jarkko Sakkinen - 2024-08-12

    I.e. this can be closed.

     
  • Oswald Buddenhagen

    • status: posted --> closed-rejected
     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.