Re: [PATCH] build: also consider builds off of git with `git clone --depth 1`
mailbox synchronizer
Brought to you by:
ossi
From: Paymon <dar...@gm...> - 2024-12-03 20:29:50
|
On Sat, Nov 30, 2024 at 11:55:33AM +0100, Oswald Buddenhagen via isync-devel wrote: > On Fri, Nov 29, 2024 at 06:21:45PM -0500, Paymon MARANDI wrote: > > any feedback? > > > yeah, sorry, i've been procrastinating and then it went out of view ... > > i don't like it, because it makes the version info useless, which would > make worse log files. adding --always to the describe command seems less > disruptive. oh, didn't know about that one. > the use case also feels a bit silly - given that the worktree is over > half a meg and the build tree several times that much, shrinking the > pack from just 2 megs to 200k seems mostly pointless. i updated the log, hopefully will add proper justification. -- Paymon |