Re: XDG_CONFIG_HOME support in mbsync

[Andreas G. <an...@gr...>]

On Sun, Nov 29, 2020 at 02:47:15PM +0100, Oswald Buddenhagen wrote:
> On Sun, Nov 29, 2020 at 08:23:45AM +0100, Andreas Grapentin wrote:
> > 2.) it attempts to open the config file at location
> > $XDG_CONFIG_HOME/mbsync/config
> > 
> any particular reason why this isn't simply $XDG_CONFIG_HOME/mbsyncrc? i see
> that a lot of apps have the extra dir, but that's just pointless noise when
> only one file is expected (of course, in principle, there can be also ssl
> certificates, but storing auxiliary files with the same file name stem
> directly in $XDG_CONFIG_HOME also has many precedents, and it would be the
> rare case here).

I have not found any text in the specification on whether any format is
to be preferred here. I think the subdirectory has the advantage of
being extendable in the future, in case of a change that adds more
configuration files

I think all of the following would be fine:
 - XDG_CONFIG_HOME/mbsync/mbsyncrc
 - XDG_CONFIG_HOME/mbsync/config
 - XDG_CONFIG_HOME/isync/mbsyncrc
 - XDG_CONFIG_HOME/mbsyncrc
and probably more.

maybe the version XDG_CONFIG_HOME/isync/mbsyncrc makes sense, in case
any other utilities that are part of isync will provide config files in
the future?


> > If this change is welcome, I can look into using XDG_DATA_HOME for
> > ~/.local/share/mbsync as well, as requested in the original feature
> > request.
> > 
> yes, absolutely.

In the interest of granularity, I'll prepare a separate patch for that,
is that ok?

Thank you for the feedback on the code changes! I have attached an
updated version of the patch below.

Best,
Andreas

-- 

------------------------------------------------------------------------------
my GPG Public Key:                 https://files.grapentin.org/.gpg/public.key
------------------------------------------------------------------------------