Isync / Bugs / #73 add support for imap id extension

shanyi - 2024-02-24

https://github.com/OfflineIMAP/offlineimap3/issues/71

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Oswald Buddenhagen - 2024-02-25

i can implement that, but the RFC states rather plainly that the server must not make operation dependent on it. it is blatantly and intentionally violating the standard.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- shanyi - 2024-02-25
  
  I completely agree with your perspective. This security check is nonsense.
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- shanyi - 2024-02-25
  
  However, I believe that implementing this feature could greatly benefit users facing similar challenges without compromising the project's integrity.
  
  Given the significant user base and the widespread use of NetEase services, accommodating their requirements becomes essential for ensuring compatibility and user satisfaction. While it's not ideal to have to adjust for such specific demands, doing so can help maintain a seamless experience for a large number of users.
  
  To address this, I propose adding a configurable option within our application. This way, users who need to interact with NetEase's servers can enable this feature, while others can leave it disabled, thus adhering to the standard behavior. This approach allows for flexibility and respects the diverse needs of our user base.
  
  Thank you very much for considering this request. I am truly grateful for your efforts in maintaining isync and for your commitment to its users. Your work does not go unnoticed, and I look forward to any possibility of accommodating this feature in the future.
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Oswald Buddenhagen - 2024-07-30

is 163.com still misbehaving this way?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Oswald Buddenhagen - 2024-11-24

status: open --> wont-fix
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Oswald Buddenhagen - 2024-11-24

due to lack of followup i'm assuming that this has become a non-issue.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Derren Brown - 2025-09-30

I have written an email to kefu@188.com on this issue, In the mean time, would you consider implement this?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Oswald Buddenhagen - 2025-09-30
  
  so it appears that the various netease domains weren't fixed ....
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
  - Derren Brown - 2025-09-30
    
    126.com, 163.com and possibly 188.com. from the response I get, I don't think they have any plan to fix this though. I couldn't even get to the tech team
    
    If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Oswald Buddenhagen - 2025-09-30

summary: Unsafe login with 163 emails --> add support for imap id extension

status: wont-fix --> open
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

they only offer this, as @shanyi posted in the link(https://help.mail.163.com/faqDetail.do?code=d7a5dc8471cd0c0e8b4b8f4f8e49998b374173cfe9171305fa1ce630d7f67ac2eda07326646e6eb0):

********************代码块区域开始********************

Properties props = new Properties(); 
props.setProperty("mail.store.protocol", "imap"); 
props.setProperty("mail.imap.host", "imap.163.com"); 
props.setProperty("mail.imap.port", "143"); 

HashMap IAM = new HashMap();
//带上IMAP ID信息，由key和value组成，例如name，version，vendor，support-email等。
IAM.put("name","myname");      
IAM.put("version","1.0.0");      
IAM.put("vendor","myclient");      
IAM.put("support-email","testmail@test.com");  
Session session = Session.getInstance(props); 

IMAPStore store = (IMAPStore) session.getStore("imap");
//下方替换对应账号和授权码
store.connect("testmail@163.com", "password"); 

store.id(IAM);

********************代码块区域结束********************

I Asked Coding Agent to fix this for me. here's what I got:

it a/src/drv_imap.c b/src/drv_imap.c
index 9b170ab..7b7f607 100644
--- a/src/drv_imap.c
+++ b/src/drv_imap.c
@@ -9,6 +9,7 @@
 #include "imap_p.h"

 #include "socket.h"
+#include "config.h"

 #include <ctype.h>
 #include <sys/wait.h>
@@ -2088,6 +2089,8 @@ static void imap_open_store_authenticate_p3( imap_store_t *, imap_cmd_t *, int )
 static void imap_open_store_authenticate2( imap_store_t * );
 static void imap_open_store_authenticate2_p2( imap_store_t *, imap_cmd_t *, int );
 static void imap_open_store_authenticate2_p3( imap_store_t *, imap_cmd_t *, int );
+static void imap_open_store_id( imap_store_t * );
+static void imap_open_store_id_p2( imap_store_t *, imap_cmd_t *, int );
 static void imap_open_store_compress( imap_store_t * );
 #ifdef HAVE_LIBZ
 static void imap_open_store_compress_p2( imap_store_t *, imap_cmd_t *, int );
@@ -2718,7 +2721,7 @@ imap_open_store_authenticate2_p2( imap_store_t *ctx, imap_cmd_t *cmd ATTR_UNUSED
                if (!ctx->caps || ctx->capability_hack)
                        imap_exec( ctx, NULL, imap_open_store_authenticate2_p3, "CAPABILITY" );
                else

-                       imap_open_store_compress( ctx );
+                       imap_open_store_id( ctx );
        }
 }

@@ -2728,7 +2731,26 @@ imap_open_store_authenticate2_p3( imap_store_t *ctx, imap_cmd_t *cmd ATTR_UNUSED
        if (response == RESP_NO)
                imap_open_store_bail( ctx, FAIL_FINAL );
        else if (response == RESP_OK)

-               imap_open_store_compress( ctx );
+               imap_open_store_id( ctx );
+}
+
+static void
+imap_open_store_id( imap_store_t *ctx )
+{
+       /* Always send ID command with hardcoded client information */
+       if (DFlags & DEBUG_NET)
+               printf( "%s: Sending ID command\n", ctx->label );
+
+       imap_exec(ctx, NULL, imap_open_store_id_p2,
+                 "ID (\"name\" \"%s\" \"version\" \"%s\" \"vendor\" \"%s\")",
+                 PACKAGE, PACKAGE_VERSION, PACKAGE);
+}
+
+static void
+imap_open_store_id_p2( imap_store_t *ctx, imap_cmd_t *cmd ATTR_UNUSED, int response ATTR_UNUSED )
+{
+       /* ID command is optional, so we ignore failures and continue */
+       imap_open_store_compress( ctx );
 }

 static void

Happy to say it actually worked!
I'm no C expert, but the code looks to me just injected an ID command after authentication, Would you take a look at this, I don't know how to do pull request on this site. @ossi

Last edit: Derren Brown 2025-10-09

Oswald Buddenhagen - 2025-10-09

which coding agent exactly was that?

the patch looks about correct, except that the actual ID string is mildly stupid. i'll have to check the spec for the correct fields and command order.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Derren Brown - 2025-10-10
  
  Zed editor with a deepseek chat model
  to be fair, it did a lot of capability and domain checks, i asked it to remove those
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

add support for imap id extension

mailbox synchronizer

Affected

Fixed In

Searches

Help

#73 add support for imap id extension

env

error

Solution to the error

Discussion