Menu ▾ ▴

#130 Sorting does not work properly: "My Opened" & "My Assigned"

open
nobody
5
2005-08-02
2005-08-02
No

Group : 4.0.4

When trying to sort, say by severity, sorting is
exclusively descending, and show closed is toggled.
Clicking on a column header should not toggle show
closed, it should sort by chosen column. In the case
that the data is already sorted by the chosen column,
the sort order should be toggled.

Here is the diff for the fix :

diff -r modules/issues/my_assigned.issues.php
/var/www/html/issue-tracker/modules/issues/my_assigned.issues.php
37c37
< $url .= $_GET['showall'] != "true" ? "&showall=true"
"";
---
> $url .= $_GET['showall'] == "true" ? "&showall=true"
"";
56c56,57
< $sql .= "ORDER BY i.".$_GET['sort']."
DESC ";
---
> $sql .= "ORDER BY i.".$_GET['sort'];
> $sql .= $_GET['reverse'] != "true" ? "
DESC" : " ASC";
diff -r modules/issues/my_open.issues.php
/var/www/html/issue-tracker/modules/issues/my_open.issues.php
37c37
< $url .= $_GET['showall'] != "true" ? "&showall=true"
"";
---
> $url .= $_GET['showall'] == "true" ? "&showall=true"
"";
46c46,47
< $sql .= "ORDER BY ".$_GET['sort']." DESC";
---
> $sql .= "ORDER BY ".$_GET['sort'];
> $sql .= $_GET['reverse'] != "true" ? " ASC" : " DESC";

Discussion


Log in to post a comment.