ISFDB Bibliographic Tools / Support Requests / #68 Consolidate viewers.py logic

Ahasuerus - 2014-10-07

Moved HTML print functions from library.py to viewers.py now that they are only called from viewers.py. This will make library.py, which is imported from many other modules, smaller:

common/library.py 1.68 common/viewers.py 1.67

Installed in r2014-235 on 2014-10-07. Keeping the SR open.

Last edit: Ahasuerus 2022-07-13
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2022-07-13

Part 2 - Started adding support for converting viewers.py functions to methods :

biblio/dumpxml.py biblio/view_submission.py common/isfdb.py edit/isfdblib.py mod/common.py mod/list.py

Installed in SVN 957 on 2022-07-13. Keeping the SR open.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2022-07-13

Part 3 - Fixed a bug introduced in Part 2. Implemented in mod/isfdblib.py, installed in SVN 958 on 2022-07-13.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2022-07-14

Part 4 - Converted Add/Edit Template to methods:

biblio/view_submission.py common/isfdb.py common/viewers.py edit/isfdblib.py edit/submit_add_template.py edit/submit_edit_template.py mod/submission_review.py

Installed in SVN 959 on 2022-07-14.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2022-07-23

Part 5 - Convert Add/Edit Verification Source to methods and improve the class layout:

common/isfdb.py common/viewers.py css/biblio_css_stub edit/submit_add_verification_source.py edit/submit_edit_verification_source.py

Installed in SVN 962 on 2022-07-23.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2022-08-13

Part 6 - Convert Add New Award Type and further improve the new classes:

common/isfdb.py common/viewers.py edit/submitnewawardtype.py

Installed in SVN 964 on 2022-07-29, but the SR wasn't updated until 2022-08-13 due to human error.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2022-08-13

Part 7 - Upgrade Make Variant and once again rewrite the new classes:

common/isfdb.py common/viewers.py edit/submitmkvar1.py edit/submitmkvar2.py

Installed in SVN 968 on 2022-08-13.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2022-08-13

Part 8 - Fixed 2 Make Variant bugs introduced in Part 7. Implemented in common/viewers.py , installed in SVN 969 on 2022-08-13.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2022-08-16

Part 9 - Fixed a bug when creating Make Variant submissions as a non-moderator:

biblio/view_submission.py common/viewers.py edit/isfdblib.py

Installed in SVN 971 on 2022-08-16.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Part 10 - Eliminate duplicate references to viewers in submit scripts:

edit/as_merge.py
edit/isfdblib.py
edit/ps_merge.py
edit/submit_add_template.py
edit/submit_add_verification_source.py
edit/submit_edit_template.py
edit/submit_edit_verification_source.py
edit/submit_new_language.py
edit/submitaddpub.py
edit/submitauth.py
edit/submitaward.py
edit/submitawardcat.py
edit/submitawardtype.py
edit/submitclone.py
edit/submitdelaward.py
edit/submitdeleteawardcat.py
edit/submitdeleteawardtype.py
edit/submitdelpub.py
edit/submitdelseries.py
edit/submitdeltitle.py
edit/submitlinkaward.py
edit/submitlinkreview.py
edit/submitmkpseudo.py
edit/submitnewaward.py
edit/submitnewawardcat.py
edit/submitnewawardtype.py
edit/submitnewpub.py
edit/submitpub.py
edit/submitpublisher.py
edit/submitpubseries.py
edit/submitrempseudo.py
edit/submitrm.py
edit/submitseries.py
edit/submittitle.py
edit/submitvariant.py
edit/ts_merge.py
edit/ts_unmerge.py

Installed in SVN 972 on 2022-08-23.

Anonymous

Add attachments
Cancel
You seem to have CSS turned off. Please don't fill out this field.

You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2022-08-26

Part 11 - Add New Language migration:

common/isfdb.py common/viewers.py

Installed in SVN 976 on 2022-08-26.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2022-08-27

Part 12 - Migrate Add Variant Title:

common/isfdb.py common/viewers.py

Installed in SVN 977 on 2022-08-26.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2022-08-27

assigned_to: Ahasuerus
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2022-08-27

Part 13 - Delete Award Type:

common/isfdb.py common/viewers.py

Installed in SVN 978 on 2022-08-27.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2022-08-28

Part 14 - Edit Award Type:

common/isfdb.py common/viewers.py

Installed in SVN 979 on 2022-08-28.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2022-08-29

Part 15 - Award Category Add/Delete/Edit:

common/isfdb.py common/viewers.py

Installed in SVN 983 on 2022-08-29.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2022-10-04

Part 16 - Series Deletion migration:

common/isfdb.py common/viewers.py

Installed in SVN 1019 on 2022-10-04.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2022-10-05

Part 17 - Publication Deletion migration:

common/isfdb.py common/viewers.py

Installed in SVN 1020 on 2022-10-05.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2022-10-06

Part 18 - Title Deletion migration:

common/isfdb.py common/viewers.py

Installed in SVN 1021 on 2022-10-06.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2022-10-07

Part 19 - Title Deletion - Review display fix:

common/SQLparsing.py common/viewers.py

Installed in SVN 1022 on 2022-10-07.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2022-10-11

Part 20 - Display cover scans for COVERART MakeVariant submissions. Implemented in common/viewers.py, installed in SVN 1026 on 2022-10-10.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2022-10-12

Part 21 - Remove Alternate Name migration:

common/isfdb.py common/viewers.py

Installed in SVN 1027 on 2022-10-12.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2022-10-13

Part 22 - Link Award migration:

common/isfdb.py common/viewers.py

Installed in SVN 1028 on 2022-10-13.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2022-10-14

Part 23 - Link Review migration:

common/isfdb.py common/viewers.py

Installed in SVN 1029 on 2022-10-14.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2022-10-14

Part 24 - Edit Publication Series migration:

common/isfdb.py common/viewers.py

Installed in SVN 1030 on 2022-10-14.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Consolidate viewers.py logic

Group

Searches

Help

#68 Consolidate viewers.py logic

Discussion