#410 Post-Python 3: CHAPBOOK bug in mod/ca_new.py

[Ahasuerus]

There is a CHAPBOOK bug in mod/ca_new.py. Line 130 of https://sourceforge.net/p/isfdb/code-svn/HEAD/tree/branches/p3/mod/ca_new.py reads:

update = "update titles set title_ttype='SHORTFICTION' where title_id=%s" % (id)

This is an attempt to change the title type of clones CHAPBOOK pubs to SHORTFICTION, but it fails because the "else" on line 135 always kicks in for CHAPBOOK pubs and the value of the variable "update" is changed to:

update = "update titles set %s='%s' where title_id=%s" % (column, CNX.DB_ESCAPE_STRING(value), id)
print("

", update)

The underlying idea, i.e. changing CHAPBOOK title types to SHORTFICTION, was introduced ca. 2010 when were only beginning to experiment with the CHAPBOOK title/publication type. It was abandoned within a few months, but, apparently, the code on line 130 was never found and removed, presumably because it wasn't working, so its presence was masked.

We need to remove line 130.