Currently, the Title screen displays all linked Reviews for the Title. As per Wiki discussions, we also want it to display any Reviews of the Variant Titles associated with this Title.
This feature requires changing function SQLloadTitleReviews(title_id) in common/SQLparsing.py
The modified function is used only in biblio/title.py; title.py doesn't have to be modified.
Instead of looking for title_relationships records for given title_id, this function should look for records 'where title_id IN (...) ' title_id is set of title ids of the canonical title and its variants.
Note that another modification of the same function would enable sorting the reviews chronologically (by using inner join with titles and adding 'order by title_copyright').
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Assigned to Roglo as per Wiki discussion.
This feature requires changing function SQLloadTitleReviews(title_id) in common/SQLparsing.py
The modified function is used only in biblio/title.py; title.py doesn't have to be modified.
Instead of looking for title_relationships records for given title_id, this function should look for records 'where title_id IN (...) ' title_id is set of title ids of the canonical title and its variants.
Note that another modification of the same function would enable sorting the reviews chronologically (by using inner join with titles and adding 'order by title_copyright').
Some examples for testing (as of 2009-07-01):
http://www.isfdb.org/cgi-bin/title.cgi?154788
(Richard Morgan's Market Forces - review of the 'pseudonymous' variant title only)
http://www.isfdb.org/cgi-bin/title.cgi?186453
(Richard Morgan's Black Man - one review of the canonical, one of variant title)
http://www.isfdb.org/cgi-bin/title.cgi?17332
(Asimov's Foundation - multiple reviews both of canonical and variant title)
Fixed in common/SQLparsing.py by change from rev 1.16 (r2009-05) to rev 1.17.
common/SQLparsing.py updated to rev 1.18 (assert removed)
Implemented in r2009-07.