Menu

#866 Create a cleanup report to find invalid prices

Approved
closed
None
5
2018-12-28
2016-02-29
Ahasuerus
No

Create a cleanup report to find invalid prices.

2018-12-27 update from Annie:

[there are also] things like 23 € (the space), 0.99€, 18,50€ and €18,50 (note the comma in the last two)

We can find them using:

            or pub_price like concat('%',CHAR(0x80),' ','%')
            or pub_price like concat('%','_',CHAR(0x80),'%')
            or pub_price like concat('%',CHAR(0x80),'%',',','%')

Discussion

  • Ahasuerus

    Ahasuerus - 2016-02-29

    Implemented in:

    common/library.py 1.94
    edit/cleanup_report.py 1.24
    edit/isfdblib.py 1.142
    nightly/nightly_update.py 1.146
    

    Installed in r2016-039 on 2016-02-28. Keeping the FR open still we still need to address spaces after the euro character.

     
  • Ahasuerus

    Ahasuerus - 2016-02-29
    • status: open --> open-accepted
     
  • Ahasuerus

    Ahasuerus - 2017-07-01

    Part 2 - Purely numeric prices:

    edit/cleanup_report.py 1.130
    nightly/nightly_update.py 1.229
    

    Installed in r2017-272 on 2017-07-01. Keeping open.

     
  • Ahasuerus

    Ahasuerus - 2018-05-30

    Part 3: Add a check for the euro sign followed by a space. Implemented in:

    edit/cleanup_report.py
    nightly/nightly_update.py
    

    Installed in SVN 122 on 2018-05-20. Keeping open.

     
  • Ahasuerus

    Ahasuerus - 2018-05-31

    Part 4 - Strip spaces after the Euro sign in prices. Implemented in scripts/strip_spaces_from_euro_prices.sql, installed in SVN 123 on 2018-05-31.

     
  • Ahasuerus

    Ahasuerus - 2018-12-28
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1 +1,11 @@
     Create a cleanup report to find invalid prices.
    +
    +2018-12-27 update from Annie:
    +
    +[there are also] things like 23 € (the space), 0.99€, 18,50€ and €18,50 (note the comma in the last two)
    +
    +We can find them using:
    +
    +                or pub_price like concat('%',CHAR(0x80),' ','%')
    +                or pub_price like concat('%','_',CHAR(0x80),'%')
    +                or pub_price like concat('%',CHAR(0x80),'%',',','%')
    
     
  • Ahasuerus

    Ahasuerus - 2018-12-28
    • status: open-accepted --> closed
     
  • Ahasuerus

    Ahasuerus - 2018-12-28

    Part 5 - Added checks for characters preceding the Euro sign and for commas after the Euro sign:

     edit/cleanup_report.py
    nightly/nightly_update.py
    

    Installed in SVN 284 on 2018-12-27. Closing the FR for now.

     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB