Menu ▾ ▴

#797 Create a cleanup report to find invalid names of UK/US parts

Approved
closed
Ahasuerus
None
5
2015-08-30
2015-04-06
Ahasuerus
No

Create a cleanup report to find invalid names of UK parts. Here are Darrah Chavey's suggestions:

(1) A birthplace containing "England" must end in one of "Kingdom of England", "England, Kingdom of Great Britain", or "England, UK";
(2) A birthplace containing "Scotland" must end in one of "Kingdom of Scotland", "Scotland, Kingdom of Great Britain", or "Scotland, UK";
(3) That ending should not contain "UK" unless the year ≥ 1801
(4) The phrase "United Kingdom" should not occur (we standardize on "UK").
And either we need to be able to "ignore" Benjamin Franklin or add a special rule for him.

A similar check on US birthplaces might be useful. For a cleanup report there, you'd want to look at all place names containing one of the 49 state names (you don't have to do "West Virginia" if you're doing "Virginia"), and make sure they all end in ", USA". Here it's particularly important to have an "Ignore this record" button, because of places like Baja California, Kingdom of Hawaii, and "Georgia, USSR".

Discussion

  • Ahasuerus

    Ahasuerus - 2015-04-13
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 Create a cleanup report to find invalid names of UK parts. Here are Darrah Chavey's suggestions:

-(1) A birthplace containing "England" must end in one of "Kingdom of England", "England, Great Britain", or "England, UK";
-(2) A birthplace containing "Scotland" must end in one of "Kingdom of Scotland", "Scotland, Great Britain", or "Scotland, UK";
+(1) A birthplace containing "England" must end in one of "Kingdom of England", "England, Kingdom of Great Britain", or "England, UK";
+(2) A birthplace containing "Scotland" must end in one of "Kingdom of Scotland", "Scotland, Kingdom of Great Britain", or "Scotland, UK";
 (3) That ending should not contain "UK" unless the year ≥ 1801
 (4) The phrase "United Kingdom" should not occur (we standardize on "UK").
  And either we need to be able to "ignore" Benjamin Franklin or add a special rule for him.
     

  • Ahasuerus

    Ahasuerus - 2015-04-13

    Changed "Great Britain" to "Kingdom of Great Britain" as per this (http://www.isfdb.org/wiki/index.php/User_talk:Dirk_P_Broer#To_UK_or_not_to_UK.3F) discussion.

     

  • Ahasuerus

    Ahasuerus - 2015-08-30
    • status: open --> closed
    • assigned_to: Ahasuerus
     

  • Ahasuerus

    Ahasuerus - 2015-08-30

    Implemented in:

    mod/cleanup_report.py 1.58
mod/common.py 1.63
nightly/nightly_update.py 1.124

    Installed in r2015-124 on 2015-08-29. Closing.

     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB