Menu

#533 Change Advanced Search of "OR" searches

Approved
open
nobody
2
2014-01-26
2010-12-22
Ahasuerus
No

Access Advanced Publication Search and enter "Author = Heinlein" OR "Publication Series = fake pub series". This search will find a relatively small subset of Heinlein's pubs because only pubs that are part of publication series will be displayed. The same problem apparently occurs with publishers, but it's harder to notice because most publication records have publishers. See MartyD's explanation of this behavior below.

Discussion

  • MartyD

    MartyD - 2011-06-25

    This will happen on any Advanced Search using properties from related tables and "OR" (it also happens with "AND", but there the behavior is expected). The example here is implemented as "Publication having an Author and having a Publication Series and either that Author is Heinlein or that Publication Series is fake pub series". The SQL does a join over all of the related tables, so the search is only considering entries having the relationships being constrained. We would have to modify this to do outer joins for each constrained relationship involved in the OR. I.e., change the meaning to be "Publication either having an Author and the author's name is Heinlein or having a Publication Series and the publication series' name is fake pub series".

     
  • Ahasuerus

    Ahasuerus - 2014-01-26

    Ticket moved from /p/isfdb/bugs/195/

     
  • Ahasuerus

    Ahasuerus - 2014-01-26
    • summary: Advanced Pub Search -- publishers/pub series are wrong --> Change Advanced Search of "OR" searches
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1 +1 @@
    -Access Advanced Publication Search and enter "Author = Heinlein" OR "Publication Series = fake pub series". This search will find a relatively small subset of Heinlein's pubs because only pubs that are part of publication series will be displayed. The same problem apparently occurs with publishers, but it's harder to notice because most publication records have publishers.
    +Access Advanced Publication Search and enter "Author = Heinlein" OR "Publication Series = fake pub series". This search will find a relatively small subset of Heinlein's pubs because only pubs that are part of publication series will be displayed. The same problem apparently occurs with publishers, but it's harder to notice because most publication records have publishers. See MartyD's explanation of this behavior below.
    
    • Group: --> Approved
    • Priority: 5 --> 2
     

Anonymous
Anonymous

Add attachments
Cancel