Menu

#3 Add AND NOT to Advanced Search

Approved
closed
None
5
2017-03-04
2007-11-22
Anonymous
No

In an advanced search of the database, checking the radio button for AND NOT generates an error due to bad SQL. I don't know Python, but it surely looks to me like changing line 23 of biblio/search.py to say "AND NOT" instead of "ANDNOT" probably is all that needs to be done.

On ISFDB my username is Davecat. I hope this is the correct way to submit a bug report. Thanks.

Discussion

  • Bill Longley

    Bill Longley - 2009-05-21

    I believe Davecat is correct and it seems to work on my local copy now. I've checked in the fix - it doesn't show up via diff as it's purely a white-space correction.

     
  • Bill Longley

    Bill Longley - 2009-05-21
    • status: open --> open-fixed
     
  • Ahasuerus

    Ahasuerus - 2009-05-30

    I have installed the new version (1.4) of the script locally and it runs, but it takes a rather long time to find the data, about 1-2 minutes for "author = heinlein AND NOT title = Friday". This could cause significant performance problems.

     
  • Ahasuerus

    Ahasuerus - 2009-05-30
    • assigned_to: nobody --> blongley
     
  • Ahasuerus

    Ahasuerus - 2009-07-31

    The "AND NOT" radio button has been removed from the Advanced search screen until we figure out how to make these searches run faster.

     
  • Ahasuerus

    Ahasuerus - 2009-08-03
    • labels: --> 1169705
    • status: open-fixed --> open-postponed
     
  • Ahasuerus

    Ahasuerus - 2009-08-03

    Changed the resolution from "Fixed" to "Postponed".

     
  • Ahasuerus

    Ahasuerus - 2009-10-04

    Moved from Bugs to Feature Requests and reworded accordingly.

     
  • Ahasuerus

    Ahasuerus - 2009-10-04
    • labels: 1169705 -->
    • summary: advanced search AND NOT does not work --> Add AND NOT to Advanced Search
    • status: open-postponed --> open-accepted
     
  • Ahasuerus

    Ahasuerus - 2017-03-03

    "is not exactly" and "does not contain" implemented in:

    biblio/adv_search_results.py 1.29
    biblio/search.py 1.51
    

    Installed in r2017-090 on 2017-03-03. Keeping open pending user feedback.

     
  • Ahasuerus

    Ahasuerus - 2017-03-03
    • assigned_to: Bill Longley --> Ahasuerus
    • Group: --> Approved
     
  • Ahasuerus

    Ahasuerus - 2017-03-04
    • status: open-accepted --> closed
     
  • Ahasuerus

    Ahasuerus - 2017-03-04

    No problems reported so far. Closing the FR.

     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB