Menu

#1376 Add additional yellow warnings for cover images

Approved
closed
None
5
2020-11-16
2020-11-07
Ahasuerus
No

Add additional yellow warnings for cover images. As per Community Portal:

"...here are the warning messages that have been proposed so far:

  1. This image is already in use by another publication
    2 The URL of this ISFDB-hosted image does not match this publication tag (display the two tags?)
  2. The URL of this Amazon-hosted image does not start with "/images/I/"

2020-11-15 update: 2 and 3 have been implemented. 1 remains outstanding; an attempt to add a new warning was unsuccessful and had to be reverted. The affected part of the ISFDB code has reached the point where it needs to be redesigned before we can add more functionality. Keeping the FR open.

Discussion

  • Ahasuerus

    Ahasuerus - 2020-11-11
    • assigned_to: Ahasuerus
     
  • Ahasuerus

    Ahasuerus - 2020-11-11

    Part 1 - Adds warnings for ISFDB-hosted images and Amazon-hosted images:

    common/viewers.py

    Installed in SVN 560 on 2020-11-11. Keeping the FR open.

     
  • Ahasuerus

    Ahasuerus - 2020-11-14
    • status: open --> closed
     
  • Ahasuerus

    Ahasuerus - 2020-11-14

    Part 2- Adds a 'This image is already in use by another publication' warning :

    common/SQLparsing.py
    common/viewers.py
    scripts/add_pub_images_index.sql
    

    Installed in SVN 561 on 2020-11-14. Closing the FR.

     
  • Ahasuerus

    Ahasuerus - 2020-11-15

    Part 3 - Disabled 'This image is already in use by another publication' warning due to bugs:

    common/viewers.py

    Installed in SVN 562 on 2020-11-15.

     
  • Ahasuerus

    Ahasuerus - 2020-11-15
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -5,3 +5,5 @@
     1.  This image is already in use by another publication
     2   The URL of this ISFDB-hosted image does not match this publication tag (display the two tags?)
     3.  The URL of this Amazon-hosted image does not start with "/images/I/" 
    +
    +2020-11-15 update: 2 and 3 have been implemented. 1 remains outstanding; an attempt to add a new warning was unsuccessful and had to be reverted. The affected part of the ISFDB code has reached the point where it needs to be redesigned before we can add more functionality. Keeping the FR open.
    
    • status: closed --> open
     
  • Ahasuerus

    Ahasuerus - 2020-11-16
    • status: open --> closed
     
  • Ahasuerus

    Ahasuerus - 2020-11-16

    Part 4 - Added a corrected version of the 'Image already on file' message:

    common/SQLparsing.py
    common/viewers.py
    

    Installed in SVN 564 on 2020-11-15. Closing the FR.

     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB