Menu ▾ ▴

#1320 Enhance the 'Title Dates after Publication Dates' cleanup report

Approved
closed
Ahasuerus
None
5
2019-12-06
2019-11-16
Ahasuerus
No

Enhance the 'Title Dates after Publication Dates' cleanup report. At this time this cleanup report is restricted to titles whose title year is after the publication year, so it ignores month mismatches.

The reason it was originally coded that way was that we wanted to go after the "low hanging fruit" first. Now that it's out of the way, we can further fine-tune the report logic. There are various permutations that may be legitimate, e.g. a 1947-00-00 EDITOR title associated with a 1947-11-00 MAGAZINE title, so we'll need to start with obviously incorrect pairs. We'll start with title/publication pairs with:

  1. the same year values
  2. non-"00" publication month values
  3. the title month after the publication month

Discussion

  • Ahasuerus

    Ahasuerus - 2019-11-16
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,4 +4,4 @@

 1. the same year values
 2. non-"00" month values
-3. the title monthafter the publication month
+3. the title month after the publication month
     

  • Ahasuerus

    Ahasuerus - 2019-12-06
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 Enhance the 'Title Dates after Publication Dates' cleanup report. At this time this cleanup report is restricted to titles whose title *year* is after the publication *year*, so it ignores month mismatches.

-The reason it was originally coded that way was that we wanted to go after the "low hanging fruit" first. Now that it's out of the way, we can further fine-tune the report logic. There are various permutations that may be legitimate, e.g. a 1947-00-00 EDITOR title associated with a 1947-11-00 MAGAZINE title, so we'll need to start with obviously incorrect pairs like the one that you have found. We can start with title/publication pairs with:
+The reason it was originally coded that way was that we wanted to go after the "low hanging fruit" first. Now that it's out of the way, we can further fine-tune the report logic. There are various permutations that may be legitimate, e.g. a 1947-00-00 EDITOR title associated with a 1947-11-00 MAGAZINE title, so we'll need to start with obviously incorrect pairs. We'll start with title/publication pairs with:

 1. the same year values
-2. non-"00" month values
+2. non-"00" publication month values
 3. the title month after the publication month
    • status: open --> closed
    • assigned_to: Ahasuerus
     

  • Ahasuerus

    Ahasuerus - 2019-12-06

    Implemented in:

    edit/cleanup_lib.py
edit/cleanup_report.py
nightly/nightly_job.py

    Installed in SVN 481 on 2019-12-06. Closing the FR.

     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB