Menu ▾ ▴

#1142 Allow up to 5 search values in Advanced Search

Approved
closed
Ahasuerus
None
5
2019-03-10
2018-04-16
Ahasuerus
No

Allow up to 5 search values in Advanced Search. Note that this change will require that all Advanced Searches be forced to choose a single AND or OR condition. Mixing and matching multiple AND/OR conditions in arbitrary searches would either cause performance problems (best case scenario) or cause the search logic to hang and possibly crash the site (worst case scenario.)

Discussion

  • Ahasuerus

    Ahasuerus - 2019-01-11
    • status: open --> open-accepted
    • assigned_to: Ahasuerus
     

  • Ahasuerus

    Ahasuerus - 2019-01-11

    Part 1 - Increased the limit to 5 in:

    biblio/adv_search_results.py
biblio/search.py

    Installed in SVN 313 on 2019-01-10. Keeping the FR open.

     

  • Ahasuerus

    Ahasuerus - 2019-01-11

    Part 2 - bug fix:

    biblio/adv_search_results.py

    Installed in SVN 314 on 2019-01-10.

     

  • Ahasuerus

    Ahasuerus - 2019-01-12

    Part 3 - Fixed dynamic drop-down lists not working for lines 4 and 5:

    css/adv_search.js

    Installed in SVN 317 on 2019-01-12.

     

  • Ahasuerus

    Ahasuerus - 2019-01-13

    Part 4 - Made AND/OR appear to the right of the search value field:

    biblio/search.py
css/adv_search.js

    Installed in SVN 318 on 2019-01-12.

     

  • Ahasuerus

    Ahasuerus - 2019-03-10
    • summary: Lift the 3 search values per Advanced Search limit --> Allow up to 5 search values in Advanced Search
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1 @@
-Lift the "3 search values per Advanced Search" limit. Instead of displaying three input lines per Advanced Search type, we should display just one line followed by a '+' button. It should be similar to the way '+' buttons work elsewhere and allow entering as many search values as needed. (Only limited by the fact that Internet Explorer has issues with URLs which contain more than 2,047 characters.) Note that this change will  require that all Advanced Searches  be forced to choose a single AND or OR condition. Mixing and matching multiple AND/OR conditions in arbitrary searches would either cause performance problems (best case scenario) or cause the search logic to hang and possibly crash the site (worst case scenario.) 
+Allow up to 5 search values in Advanced Search. Note that this change will  require that all Advanced Searches  be forced to choose a single AND or OR condition. Mixing and matching multiple AND/OR conditions in arbitrary searches would either cause performance problems (best case scenario) or cause the search logic to hang and possibly crash the site (worst case scenario.)
    • status: open-accepted --> closed
     

  • Ahasuerus

    Ahasuerus - 2019-03-10

    Based on Wiki discussions, I have changed the FR description from "use "+" to allow an unlimited number of selection criteria" to "display 5 selection criteria".

    The changes implemented in January 2019 have been live for a couple of months now and the functionality is stable. Closing the FR. Subsequent changes to the Advanced Search software will be documneted in additional FRs/SRs.

     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB