Menu

#808 archive.org URLs do not produce yellow warnings or cleanup exceptions

v1.0 (example)
closed-fixed
None
5
2022-07-24
2022-07-23
No

Only a short note:
http://www.isfdb.org/cgi-bin/ea.cgi?1557
Author Image supplied by web_archive.org reference http://www.isfdb.org/cgi-bin/web.archive.org
which isn't avallable as a cgi-bin
Image is supplied by http://www.fantascienza.com/magazine/imgbank/NEWS/AUTORI/saxton-josephine%7F.jpg
Maybe an Problem with BuildDisplayURL->RecognizedDomains?

2022-07-24 update: It turns out that this bug was due to a flaw in the logic which identifies unrecognized/unsupported URLs. The logic looks for URLs which contain supported domain names, so a URL with "fantascienza.com" in it is accepted even if the URL's actual domain is "archive.org". "archive.org" is not supported by the ISFDB, but this flaw lets unsupported archive.org URLs slip in without a yellow warning or being flagged by a cleanup report.

Discussion

  • Ahasuerus

    Ahasuerus - 2022-07-23

    Yup, looks like a bug. I'll investigate when I wrap up the current patch. Thanks for the heads-up!

     
  • Ahasuerus

    Ahasuerus - 2022-07-24
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -4,3 +4,5 @@
     which isn't avallable as a cgi-bin
     Image is supplied by http://www.fantascienza.com/magazine/imgbank/NEWS/AUTORI/saxton-josephine%7F.jpg
     Maybe an Problem with BuildDisplayURL->RecognizedDomains?
    +
    +2022-07-24 update: It turns out that this bug was due to a flaw in the logic which identifies unrecognized/unsupported URLs. The logic looks for URLs which *contain* supported domain names, so a URL with "fantascienza.com" in it is accepted even if the URL's actual domain is "archive.org".  "archive.org" is not supported by the ISFDB, but this flaw lets unsupported archive.org URLs slip in without a yellow warning or being flagged by a cleanup report.
    
     
  • Ahasuerus

    Ahasuerus - 2022-07-24
    • summary: web_archive.org missing in RecognizedDomains? --> archive.org URLs do not produce yellow warnings or cleanup exceptions
    • assigned_to: Ahasuerus
     
  • Ahasuerus

    Ahasuerus - 2022-07-24
    • status: open --> closed-fixed
     
  • Ahasuerus

    Ahasuerus - 2022-07-24

    Fixed in:

    common/viewers.py
    edit/cleanup_report.py
    nightly/nightly_cleanup.py
    

    Installed in SVN 963 on 2022-07-24. The offending URL will appear on the cleanup report tomorrow morning.

     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB