Menu

#1269 Add a default conjunction and start value to Advanced Search

Approved
closed
None
5
2019-04-18
2019-04-17
Marc Kupper
No

I have some internal scripts that I use at times to look up things on ISFDB using adv_search_results.cgi

Recently some of the searches would return an error "Error: Only AND and OR conjunction values are allowed" Apparently code was added on the ISFDB side to check for a C= argument and to kick out an error if it's not present. Many of my searches only have one term and so I had not included a conjunction. For example, to look up an ISBN I had used:
http://www.isfdb.org/cgi-bin/adv_search_results.cgi?TYPE=Publication&START=0&ORDERBY=pub_price&USE_1=pub_isbn&O_1=exact&TERM_1=076534033X
This now needs a C=AND or
http://www.isfdb.org/cgi-bin/adv_search_results.cgi?TYPE=Publication&START=0&ORDERBY=pub_price&C=AND&USE_1=pub_isbn&O_1=exact&TERM_1=076534033X

While I have fixed my scripts to include C=AND I suspect the ISFDB code should check and only require conjunctions if two or more terms are provided or to default to AND. OR based searches should be rare and the submitter can use C=OR if they need that conjunction.

Related to this is that START seems to be a required parameter. Can this default to zero?

Discussion

  • Ahasuerus

    Ahasuerus - 2019-04-18

    Ticket moved from /p/isfdb/bugs/726/

     
  • Ahasuerus

    Ahasuerus - 2019-04-18
    • summary: adv_search_results.cgi - add a default conjunction --> Add a default conjunction and start value to Advanced Search
    • Group: v1.0 (example) --> Approved
     
  • Ahasuerus

    Ahasuerus - 2019-04-18
    • status: open --> closed
    • assigned_to: Ahasuerus
     
  • Ahasuerus

    Ahasuerus - 2019-04-18

    Implemented in biblio/adv_search_results.py, installed in SVN 395 on 2019-04-18. Closing the FR.

     

Anonymous
Anonymous

Add attachments
Cancel