Menu

#593 Incorrect hyphenation of Tor ISBNs

v1.0 (example)
closed-fixed
None
5
2016-06-12
2015-12-07
Marc Kupper
No

The publication record http://www.isfdb.org/cgi-bin/pl.cgi?207269 is being displayed with ISBN "978-0-765-31282-2 [0-765-31282-4]". The publication is stating 0-7653-1282-4 and 978-0-7653-1282-2.

library.py / convertISBN(isbn) has some special case code for ISBN 0-765-... as Tor used 0-765-3xxxx-x formatted ISBNs in their books up to 2007. In 2007 Tor started formatting the ISBN as 0-7653-xxxx-x.

Unfortunately, Tor does not allocate their ISBNs sequentially meaning we can't inspect the remainder to decide if 0-765-3xxxx-x or 0-7653-xxxx-x formatting should be used.

One option though is convertISBN() can to look at the original ISBN pased to it (after stripping puctuation) and if it's an ISBN10 to use 0-765-3xxxx-x otherwise to use 0-7653-xxxx-x. We are already watching for and correcting publication records for works published in 2008 or later and correcting them to use ISBN13.

We also have special case code for ISBN 0-812-5... and should format those as 0-812-5xxxx-x if the original ISBN is an ISBN 10 otherwise to use 0-8125-xxxx-x

If we are still storing the user punctuated ISBN in pub_isbn then isbnVariations() should be updated to generate both 7653 / 8125 styles.

Discussion

  • Ahasuerus

    Ahasuerus - 2016-06-12
    • status: open --> closed-fixed
    • assigned_to: Ahasuerus
     
  • Ahasuerus

    Ahasuerus - 2016-06-12

    Fixed in common/isbn.py 1.2, installed in 2016-094. Closing.

     

Anonymous
Anonymous

Add attachments
Cancel