Menu ▾ ▴

#581 Edit forms ignores certain changes to multiple fields

v1.0 (example)
closed-fixed
Ahasuerus
None
5
2015-09-17
2015-09-15
Ahasuerus
No

Edit forms ignores certain changes to multiple fields. For example, if a record has two "Web page" values, both "aaa", changing one of them to "a" won't be processed at submissions creation time. This is due to the fact that when the software checks if the new Webpages are the same as the old ones, it checks whether all old values are present among the new ones. It should also check that all new values are present among the old ones.

Discussion

  • Ahasuerus

    Ahasuerus - 2015-09-17
    • summary: Edit Title occasionally ignores some submitted changes --> Edit forms ignores certain changes to multiple fields
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,3 +1 @@
-Edit Title occasionally ignores some submitted changes. For example, changing a "Web page" value from "ö" to "öö" doesn't get recorded in the submission.
-
-The details are dependent on the nature of what has been submitted, but the cause of the problem is in function EvalField within edit/submittitle.py. Line 33 checks "if len(newField) == len(oldField)", which may be incorrect because oldField needs to be escaped for the comparison to be valid. Also, checking "if XMLescape(subvalue) not in newField" may not right -- further investigation is required. We will also want to consolidate all "EvalField" functions to avoid logic fragmentation.
+Edit forms ignores certain changes to multiple fields. For example, if a record has two "Web page" values, both "aaa", changing one of them to "a" won't be processed at submissions creation time. This is due to the fact that when the software checks if the new Webpages are the same as the old ones, it checks whether all *old* values are present among the new ones. It should also check that all *new* values are present among the old ones.
    • assigned_to: Ahasuerus
     

  • Ahasuerus

    Ahasuerus - 2015-09-17

    Updated the description based on further research.

     

  • Ahasuerus

    Ahasuerus - 2015-09-17
    • status: open --> closed-fixed
     

  • Ahasuerus

    Ahasuerus - 2015-09-17

    Fixed in:

    edit/isfdblib.py 1.106
edit/submitauth.py 1.25
edit/submitawardcat.py 1.6
edit/submitawardtype.py 1.13
edit/submitpublisher.py 1.13
edit/submitpubseries.py 1.12
edit/submitseries.py 1.19
edit/submittitle.py 1.27

    Installed in r2015-138 on 2015-09-16. Closing the Bug report.

     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB