Menu ▾ ▴

#327 Edit forms allow multiple adjacent spaces in entered data

v1.0 (example)
closed-fixed
Ahasuerus
Moderator Interface (36)
5
2014-01-23
2013-02-06
Ahasuerus
No

Edit forms allow multiple adjacent spaces when entering new data. Later on, the same edit forms replace double spaces with a single space when the record is pulled up for editing, but they do it inconsistently, which results in confusing behavior. We need to change all data entry forms so that multiple adjacent spaces would be replaced with a single space at data entry time.

Discussion

  • Ahasuerus

    Ahasuerus - 2013-02-06

    Update: The problem only appears to affect some pubs. It's not clear what distinguishes the afflicted subset from the majority, perhaps the use of tabs and double spaces?

     

  • Ahasuerus

    Ahasuerus - 2013-02-06
    • summary: Pun Edit approval mishandles contents titles with colons --> Pub Edit approval mishandles contents titles with colons
    • assigned_to: nobody --> ahasuerus_isfdb
     

  • Ahasuerus

    Ahasuerus - 2014-01-22
    • summary: Pub Edit approval mishandles contents titles with colons --> Edit forms allow multiple adjacent spaces in entered data
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1 @@
-On the "Proposed Publication Update Submission" page, if a Contents title contains a colon, the logic will display the title as changed even if there are no changes. The problem is apparently in edit/submitpub.py since it adds these titles to the submission body.
+Edit forms allow multiple adjacent spaces when entering new data. Later on, the same edit forms replace double spaces with a single space when the record is pulled up for editing, but they do it inconsistently, which results in confusing behavior. We need to change all data entry forms so that multiple adjacent spaces would be replaced with a single space at data entry time.
    • Group: --> v1.0 (example)
     

  • Ahasuerus

    Ahasuerus - 2014-01-22

    Changed the description now that the underlying problem has been identified.

     

  • Ahasuerus

    Ahasuerus - 2014-01-22
    • status: open --> closed-fixed
     

  • Ahasuerus

    Ahasuerus - 2014-01-22

    Fixed in:

    common/library.py 1.37
edit/submittags.py 1.8
scripts/remove_duplicate_spaces.py 1.1

    Installed in r2014-52 on 2014-01-21. Closing.

     

  • Ahasuerus

    Ahasuerus - 2014-01-23

    Part 2: Changed the logic not to strip newline characters, which was adversely affecting Notes. Implemented in common/library.py 1.38, installed in r2014-56 on 2014-01-22.

     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB