#33 Can't merge more than ~20 records at once

[Marc Kupper]

This is a potential bug that needs to be tested/verified. The source report is http://www.isfdb.org/wiki/index.php/ISFDB:Help_desk#Merging_Editor_Records

I attempted to merge over 20 editor records today in one merge, I found that only 17 or so of the records appeared in the approval screen on the Moderator page. I'm assuming that this is a coding issue. Does anybody have any clue what would have happened to the additional 10 or so records had I actually approved the edit? [[User:CoachPaul|CoachPaul]] 15:35, 11 October 2008 (UTC)

:Yes, I ran into this limitation a couple of years ago when I was trying to merge a bunch of {{a|Robert Louis Stevenson}} titles. I don't think I ever tested what will happen if you try approving a merge that big, though. Probably won't trigger the Apocalypse, but then again, why take chances? :) [[User:Ahasuerus|Ahasuerus]] 17:08, 11 October 2008 (UTC)

[Ahasuerus]

Root cause identified: mod/ta_merge.py has the following statement in it:

RecordIds = [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0]

which limits the number of merged records to 20. It needs to be changed to allow an arbitrary number of records.

[Ahasuerus]

Fixed in r2013-91. Closing.

[Ahasuerus]

Forgot to close the last time. Closing for real now.