#85 Error when logging in from the Key Maintenance page

[Ahasuerus]

If a user is viewing the Key Maintenance page when logged out, he has two ways to log in. The first one is via the URL embedded in the message "Login required to edit. You have to login to edit data." in the main frame, which links to http://www.isfdb.org/cgi-bin/dologin.cgi?0+0 and works fine. The second way is via "Log In" in the NavBar, which links to http://www.isfdb.org/cgi-bin/dologin.cgi?index.cgi and errors out with the following error:

<type 'exceptions.IndexError'> Python 2.5: /usr/bin/python
Sat Jul 25 12:17:05 2009

A problem occurred in a Python script. Here is the sequence of function calls leading up to the error, in the order they occurred.
/var/www/cgi-bin/dologin.cgi in ()
19
20 PrintHeader("Login")
21 PrintNavbar('login', 0, 0, 0, 0)
22 LoginPage(sys.argv[1], sys.argv[2])
23 PrintTrailer('login', 0, 0)
LoginPage = <function LoginPage at 0x9f570d4>, sys = <module 'sys' (built-in)>, sys.argv = ['/var/www/cgi-bin/dologin.cgi', 'index.cgi']

<type 'exceptions.IndexError'>: list index out of range

We should either fix the link in the NavBar to work correctly or, better yet, remove the "Key Maintenance" option from the NavBar when the user is not logged in.

[Ahasuerus]

Fixed in common/navbar.py 1.6, biblio/common.py 1.28, edit/isfdblib.py 1.9, mod/isfdblib.py 1.9. Implemented in r2009-26.