Menu

#38 ISBN13 does not link to Amazon and other sites

closed-fixed
MartyD
None
5
2009-06-08
2008-11-12
Marc Kupper
No

If someone enters an ISBN13 the link to various site options try to link using this directly rather than first converting it to an ISBN10 (if possible).

Example http://www.isfdb.org/cgi-bin/pl.cgi?207157

Discussion

  • MartyD

    MartyD - 2009-05-23

    This is fixed by the check ins of 23-MAY-2009. A pub's ISBN is now converted to an ISBN-10 before being used in the nav bar links.

     
  • Ahasuerus

    Ahasuerus - 2009-05-27
    • assigned_to: nobody --> marty-d
     
  • MartyD

    MartyD - 2009-05-27

    All of the navigation links will now get ISBN10, regardless of the pub's original ISBN format. Modified PrintNavBar() in common.py to convert the pub's ISBN to ISBN10 and use the converted result in the link.

     
  • MartyD

    MartyD - 2009-05-27
    • status: open --> open-fixed
     
  • Kevin Pulliam

    Kevin Pulliam - 2009-05-28

    You may want to include a 979 Prefix check in that conversion to ISBN10. ISBN13's with 979 will not convert to ISBN10's (Though we are several (many?) years away from 979's hitting the street).

     
  • Bill Longley

    Bill Longley - 2009-05-31

    This needs more validation in PrintNavBar - I just got a nasty python error looking at a Magazine with a valid ISSN (specifically, "CLRKSWRLDB2007"). Checking for a leading # isn't enough.

     
  • Ahasuerus

    Ahasuerus - 2009-06-08

    Fixed in r2009-02.

     
  • Ahasuerus

    Ahasuerus - 2009-06-08
    • status: open-fixed --> closed-fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB