#22 Double quotes in author names not escaped

[Marc Kupper]

I did an advanced search for D% Cook in an effort to locate all people whose first name start with D and whose last name is Cook. Among the results listed was
8604 David "Zeb" Cook

If I click on the 8604 it takes me to http://www.isfdb.org/cgi-bin/edit/editauth.cgi?8604 and the canonical name is displayed as "David " (without the quotes which I included so you can see the trailing space).

From the search results if I click on David "Zeb" Cook it takes me to http://www.isfdb.org/cgi-bin/ea.cgi?David%20 and "Author not found: David" is displayed.

I know that in in the database that authors.author_canonical contains 'David "Zeb" Cook'

For now, I corrected record 8604 to use "David 'Zeb' Cook"

There are two display issues
1) ap_search.cgi needs to escape " into %22 for the author URLS.
2) editauth.cgi needs to drop the entire field contents into the edit box.

In the 2008-04-21 database backup there are nine authors with double quotes in their canonical names
Dale "Slade" Henson
David "Zeb" Cook
EV "Gus" Gustafson
Wilson "Wunan" Tortosa
Robert Michael "Bobb" Cotter
Charles "Pete" Conrad, Jr.
George "Lan" Laskowski
Dr. Samuel "Uncle Kage" Conway
E. E. "Doc" Smith

[Ahasuerus]

Note that the editing software currently drops anything after the first quote in the Author name and needs to be fixed as well.

[Ahasuerus]

Related to Bug 1743286.

[Ahasuerus]

Creation of canonical names with double quotes disallowed in Author Edit as of r2009-14. We still need to add logic to automatically convert double quotes to single quotes when editing Titles and Pubs.

[Ahasuerus]

All author records with double quotes in them have been changed to use single quotes. The "Author Edit" screen now gives you an error if you try to enter double quotes in the canonical name. All other screens where Title and Pub Authors can be entered have been changed so that double quotes are automatically converted to single quotes before a submission is created.