Re: [Iscsitarget-devel] [PATCH] Persistent Reservations

[Shivaram U. <shi...@qu...>]

Oops, sorry i meant to send this change

-	if (force || volume->reserve_sid == sid)
-		volume->reserve_sid = 0;
-	else
+	if (reservation->type == RESERVATION_TYPE_RESERVE &&
+		(force || reservation->sid == sid)) {
+		reservation->is_reserved = 0;
+		reservation->type = 0;
+		reservation->sid = 0;
+	} else {
 		err = -EBUSY;
+	}

Attached the modified diff again :-)

On Wed, Aug 31, 2011 at 7:05 PM, Shivaram Upadhyayula
<shi...@qu...> wrote:
> A small change to the original patch
>
> In volume_release() is_reserved should be set to zero and not 1. This
> is for force release of a non persistent reservation
>
> +       if ((force && reservation->type == RESERVATION_TYPE_RESERVE)
> +               || reservation->sid == sid) {
> +               reservation->is_reserved = 0;
>
> Attached the modified patch again for your reference.
>
> Regards,
> Shivaram
>
> On Wed, Aug 31, 2011 at 3:56 PM, Arne Redlich
> <arn...@go...> wrote:
>> Without having looked at the patch yet: wow, thanks a lot! I'll try to
>> review it ASAP.
>>
>> Thanks,
>> Arne
>>
>> 2011/8/31 Shivaram Upadhyayula <shi...@qu...>:
>>> Hi All,
>>>
>>> Attached is a patch for SPC3 Persistent Reservations support. Most of
>>> the code is based on our storage virtualization product which i'm
>>> allowed to open source. Rest of the changes involved adapting the code
>>> for iscsi interface and IET code.
>>>
>>> Pending is "REGISTER AND MOVE" service action for a PERSISTENT RESERVE
>>> OUT command, i'm not yet sure on how to implement this for IET.
>>>
>>> Code with the patch applied successfully passed the Failover cluster
>>> tests for persistent reservations on Windows Server 2008 R2. Unrelated
>>> to persistent reservations, the failover cluster tests failed for SCSI
>>> VPD 83 page. It seems that naa identifier should fix that issue.
>>>
>>> Regards,
>>> Shivaram
>>>
>>> --
>>> Reduce Storage expenditure with QUADStor Storage Virtualization
>>> http://www.quadstor.com
>>>
>>> ------------------------------------------------------------------------------
>>> Special Offer -- Download ArcSight Logger for FREE!
>>> Finally, a world-class log management solution at an even better
>>> price-free! And you'll get a free "Love Thy Logs" t-shirt when you
>>> download Logger. Secure your free ArcSight Logger TODAY!
>>> http://p.sf.net/sfu/arcsisghtdev2dev
>>> _______________________________________________
>>> Iscsitarget-devel mailing list
>>> Isc...@li...
>>> https://lists.sourceforge.net/lists/listinfo/iscsitarget-devel
>>>
>>>
>>
>
>
>
> --
> Reduce Storage expenditure with QUADStor Storage Virtualization
> http://www.quadstor.com
>



-- 
Reduce Storage expenditure with QUADStor Storage Virtualization
http://www.quadstor.com