From: Linus W. <tr...@df...> - 2006-04-12 20:03:19
Attachments:
smsc-ircc2.c.patch
|
After some testing I edited the patch again, now it will proceed to try to configure the chip even if the ALi ports can not be configured, which makes sense since some bridges may come preconfigured to values we do not support. This will be the last one for a few days, easter holidays. Please spend your weekends testing this if you have smsc hardware that does not init :-) Linus |
From: Samuel O. <sam...@no...> - 2006-04-12 22:08:49
|
Hi Linus, On Wed, 12 Apr 2006, ext Linus Walleij wrote: > After some testing I edited the patch again, now it will proceed to > try to configure the chip even if the ALi ports can not be configured, > which makes sense since some bridges may come preconfigured to values we > do not support. Looks good to me, thanks a lot. I did a couple modifications to your patch: - Some switch() {case...} identation stuff. - preconfigure_ali_port() returns void: it was returning -ENODEV only when the configured port was unknown. We will never take this reason in account as we want to keep configuring the chip anyways, so we'd better returning void. Cheers, Samuel. |