#5 make_lstar_shell_splitting1

[Josef Koller]

Hi everybody,

I noticed a strange results when calling make_lstar_shell_splitting1 in onera_desp_lib.f. After you rewrote the large portions of this file to fix the L* calculations, multiple coordinates didn't seems to work. Instead I kept getting the same results independent of xin1, xin2, xin3. I tracked down the problem to line 265, 266 in onera_desp_lib.f.

I think instead of

call get_coordinates ( sysaxes, xIN1, xIN2, xIN3,
6 alti, lati, longi, xGEO )

they should be

call get_coordinates(sysaxes,xIN1(isat),xIN2(isat),xIN3(isat),
6 alti, lati, longi, xGEO )

There might be other issues but now at least I seem to get more reasonable results.

This brings me to another but related topic: I've been involved in a couple of software projects and recently we decided to implement some standard software testing procedures. We wrote a very simple test script calling every function with some standard numbers and compare the results to the expected results. This approach is called unit testing and really helped us track down many silly bugs that would have gone unnoticed otherwise. I don't mean to sound condascending but this could be food for thought and could greatly help to improve the quality of irbem-lib.

Cheers,

Josef