Re: [Ipsec-tools-devel] [PATCH v3 0/5] Fix musl libc build issues

[Jörg K. <joe...@em...>]

On Mo, 2016-05-09 at 02:28 -0600, Reinoud Koornstra wrote:
> On Mon, May 9, 2016 at 1:19 AM, Jörg Krause <joe...@em...
> cks> wrote:
> > On So, 2016-05-08 at 23:34 -0600, Reinoud Koornstra wrote:
> >> On Sun, May 8, 2016 at 4:43 AM, Jörg Krause <joerg.krause@embedded
> .ro
> >> cks> wrote:
> >> > This series of patches fix build issues with the musl C library
> >> > [1].
> >> >
> >> > musl is used as the default C library in OpenWRT and Alpine and
> is
> >> > supported by other Linux distros (Gentoo, Arch, Debian) and
> >> > projects
> >> > (Buildroot, Rust, ...).
> >> >
> >> > Short summary about the patches:
> >> > 1) Fix missing definition of __P() macro
> >> > 2) Remove unneeded <sys/sysctl.h>
> >> > 3) Check for GLOB_TILDE
> >> > 4) Check for strtouq
> >> > 5) Fix redirection of <sys/signal.h>
> >> >
> >> > As the projects CVS repository on sourceforge is outdated, I
> >> > created
> >> > the patches from the sources with the version 0.8.2.
> >> >
> >> > [1] http://www.musl-libc.org
> >> >
> >> > Changes v2 -> v3:
> >> >  * do not get rid of __P, but include the compatibility header
> >> > gnuc.h
> >> > whenever needed (suggested by Rainer Weikusat)
> >>
> >> Why keep the __P macro? it's ancient now and if musl can't deal
> with
> >> it, but compiles without it, then we should remove it if uclibc-
> ng,
> >> glibc and musl can compile all. You are suggesting to include
> gnuc.h
> >> in ipsec-tools?
> >> Also good with me, however, then we must maintain that file as
> well
> >> and keep it in check with newer versions.
> >> As of now I do not understand why we should keep __P, what does it
> >> bring us that we otherwise wouldn't have?
> >
> > The only feedback I got for the patch was from Rainer Weikusat, who
> > proposed to stay with __P and use the gnuc.h instead [1].
> >
> > Note, that gnuc.h is already part of ipsec-tools. It's in the
> racoon
> > subdirectory. I moved it, so it is available for the sources of the
> > other subdirectories.
> >
> > I do not have a strong opinion if __P should be removed or not.
> 
> Well, .... I don't really think it's necessary to keep.
> However, NetBSD also has racoon and likely keeps __P.
> Maybe for that sake we should keep it, not sure.
> 
> >
> > Btw, who is maintaining this project?
> >
> 
> We all do in a way.
> I Proposed a patch for 0.8.3
> I need to spilt that patch up in different ones.
> Secondly, Rainer said there is still a leak present, but had no time
> yet to patch it up and logically didn't want 0.8.3 with that leak
> present.
> When he will publish the patch, I'll make a list of patches and
> submit it.
> Timo Terras offered to review it and create 0.8.3 as he's the lead.
> Despite what lots of people may think, there is still a fairly large
> community using ipsec-tools.

That's good news!

> By all means, if anybody will see something missing from the list
> that
> i'll propose, feel free to comment.

Is there an up-to-date repository (preferable git)? This would ease
patch creation.

Best regards
Jörg Krause