[Ipsec-tools-devel] [PATCH] Bug fixes and cleanups

[Timo T. <tim...@ik...>]

Hi,

Bunch of bug fixes and cleanups.

ports-cleanup.diff:
- many places use switch (address_family) for setting/getting port
  this replaces them to use set_port/extract_port. improves readability,
  maintenance and reduces code size
- changes the byte order getbyaddrsport() returns for readability and
  consistency. also this function had bug: sin{,6}_port (network byte
  order) was compared to PORT_ISAKMP (host byte order)
- similar bug in ipsec_doi.c:ipsecdoi_checkid1() sin_port was not
  converted to host byte order, but used as if it was in host byte order

ipsec-sa-compare-fix.diff:
- the patch i posted yesterday fixed to use extract_port()

close-on-exec.diff:
- set socket fd:s to be closed on exec. otherwise the phase1 up/down
  script will inherit those fd:s and can cause havoc:
	- send/receive stuff from system sockets (e.g. route socket)
	- if the scripts blocks, it'll keep open the event pipes
	  open to racoonctl and in some cases can cause dead locks

event-fix.diff:
- my event patches used wrong event number definition for phase2 up
  notification. this oneliner fixes it.

Cheers,
  Timo