Re: [Ipsec-tools-devel] [PATCH 1/2]: allow racoon to use security contexts

[Joy L. <la...@au...>]

>Joy Latten <la...@au...> wrote:
>
>>  int pfkey_send_update __P((int, u_int, u_int, struct sockaddr *,
>>       struct sockaddr *, u_int32_t, u_int32_t, u_int,
>>       caddr_t, u_int, u_int, u_int, u_int, u_int, u_int32_t, u_int64_t,
>> -     u_int64_t, u_int64_t, u_int32_t));
>> +     u_int64_t, u_int64_t, u_int32_t,
>> +     u_int8_t, u_int8_t, caddr_t, u_int16_t));
>
>I'll take care of your patch, but I have a concern about pfkey_*
>arguments: the list is getting insane. At some point we will have to
>pass a pointer to a struct instead of such a bunch of arguments. The
>question is: before forking the 0.7 branch or after?
>
>Anyone has an opinion?

I was wondering if anyone had gotten a chance to take a look at this patch
and if there were any review comments. I'd be happy to help in any way 
that I can. I can also re-submit the patch. :-)

Regards,
Joy