Re: [Ipodlinux-devel] 3g firewire success

[PALFFY D. <dpa...@ra...>]

On Wed, 11 Feb 2004, Bernard Leach wrote:

> > Hold off generates three: 0x20/0x20; 0xdf/0xff; 0x40/0xbf. The first
> > interrupt from hold on won't be easy to block since it's a perfectly valid
> > input from wheel motion, too. What does the apple firmware do?
>
> Typo fixed... thanks.
>
> As for the interrupts, the multiple interrupts are caused by incorrect
> processing in the keyboard driver.

With the patch applied I get three interrupts for hold on, too, it didn't
change hold off. At hold on, the first interrupt was problematic. It
always looks like a wheel movement, so your patch doesn't change anything.
Also your patch doesn't change hold off behaviour. I think we should put a
short delay in the interrupt handler, and read state then, since we get an
interrupt on all pins, but the first one arriving is on some wheel inputs.
Diags mode also does it wrong (a hold on/off sometimes causes all keys
pass the test), so we can't look there...

--
Daniel
			...and Linux for all.