Re: [Ipodlinux-devel] 3g firewire success

[PALFFY D. <dpa...@ra...>]

Hi!

> Thanks for the testing.  I've commited the fix to the iPod firewire
> driver now so once the public CVS server is updated (v1.6 has the fix)
> only the #define needs to be modified.

Thanks. I've looked at your other changes. Some comments about keyboard.c:
The 3G HOLD_SWITCH_IS_ON macro has a typo - you meant &, not &&.
Otherwise, the hold botton works a little bit more complicated than
before. Hold on generates two interrupts - source/state: 0xX0/0xff;
0xff/0x00, where X was 4, 8 or c depending on the current wheel state.
Hold off generates three: 0x20/0x20; 0xdf/0xff; 0x40/0xbf. The first
interrupt from hold on won't be easy to block since it's a perfectly valid
input from wheel motion, too. What does the apple firmware do?

> On the server side I will see about updating the documentation shortly.
> But basically the host nodemgr.c needs to be patched (commenting out the
> do_irm_duties) and the eth1394.c driver replaced with the one from the
> ipodlinux CVS (this already contains the patch mentioned in the manual).

eth1394.c doesn't seem to contain the patch from the manual.

--
Daniel
			...and Linux for all.