Menu

Obsolete (git) Merge Request #4: Fix for Issue 374 - PICMG LED SET parameter checking too fierce (rejected)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Robert Sworder wants to merge 2 commits from /u/rsworder-ms/ipmitool/ to master, 2018-04-03

As discussed, if we're setting the LED Off or On, then the duration parameter should be ignored - but should also be set to 0.

Commit Date  
[68da6e] by Robert Sworder Robert Sworder

ID:374 - Also allow any duration if we're setting the LED off.

2015-03-10 16:44:13 Tree
[40f389] by Robert Sworder Robert Sworder

LED ON Duration doesn't matter if it's being set ON, and should be set
to 0.

2015-03-10 16:28:42 Tree

Discussion

  • Robert Sworder

    Robert Sworder - 2015-03-11

    Please close this merge request - a new one is coming.

     
  • Alexander Amelkin

    Rejecting as per discussion in [#374]

     

    Related

    Bugs (use GitHub instead): #374

  • Alexander Amelkin

    • Status: open --> rejected
     

Log in to post a comment.